Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for non-numpy dtypes #6308

Open
hoxbro opened this issue Jul 4, 2024 · 1 comment
Open

Improve support for non-numpy dtypes #6308

hoxbro opened this issue Jul 4, 2024 · 1 comment
Labels
type: enhancement Minor feature or improvement to an existing feature

Comments

@hoxbro
Copy link
Member

hoxbro commented Jul 4, 2024

We should improve the support for different dtypes; currently, we really only support numpy.

dtypes which make sense to support:

@hoxbro hoxbro added the type: enhancement Minor feature or improvement to an existing feature label Jul 4, 2024
@hoxbro
Copy link
Member Author

hoxbro commented Aug 17, 2024

Another examples is inspect_polygons does not seem to like string[pyarrow] (reduced example of NYC buildings)

import dask
import holoviews as hv
import spatialpandas.io as sio
from holoviews.operation.datashader import datashade, inspect_polygons

hv.extension("bokeh")
dask.config.set({"dataframe.convert-string": False})  # False works

# http://s3.amazonaws.com/datashader-data/nyc_buildings.parq.zip
ddf = sio.read_parquet_dask("./data/nyc_buildings.parq").persist()

ddf.dtypes  #  type and name is `pyarrow[string]` or object.

polys = hv.Polygons(ddf)
shaded = datashade(polys)
hover = inspect_polygons(shaded).opts(fill_color="red", tools=["hover"])
(shaded * hover).opts(width=800, height=800)

Edit: It does not seem to be a problem with non-numpy dtype directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant