Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opts magics should validate non-existing Elements #625

Closed
philippjfr opened this issue Apr 20, 2016 · 3 comments
Closed

Opts magics should validate non-existing Elements #625

philippjfr opened this issue Apr 20, 2016 · 3 comments
Assignees
@jlstevens
Labels
type: feature A major new feature
Milestone
v1.7.0

Comments

@philippjfr
Copy link
Member

Currently when you accidentally request to style a non-existing Element using the opts magic it will simply accept it without question. It would be good if we could validate the opts magic specification and check that there is actually an entry in the OptsTree for the requested Element type.
@jlstevens
Copy link
Contributor

Agreed. This shouldn't be hard to do but it is low priority unless you tell me otherwise.

@jlstevens jlstevens self-assigned this Apr 20, 2016
@jlstevens jlstevens added this to the 1.4.4 milestone Apr 20, 2016
@philippjfr philippjfr modified the milestones: v1.6.0, 1.4.4 Apr 20, 2016
@philippjfr philippjfr added the type: feature A major new feature label Apr 10, 2017
@jlstevens jlstevens mentioned this issue Apr 11, 2017
Merged
@jlstevens
Copy link
Contributor

Fixed in the PR referenced above. Closing.

@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jlstevens jlstevens

Labels
type: feature A major new feature
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@jlstevens @philippjfr