-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/util fails due to pandas 1.3 refactoring ABCIndexClass to ABCIndex #5009
Comments
I just ran into the same thing - had to pin |
I also just ran into this problem. Hopefully, this can be fixed before the next release. |
@kgullikson88 I think that's all that's needed, a PR would be massively appreciated. |
@philippjfr I'm not seeing any specific developer instructions so I will just start making the change and adding a test case if possible. Please let me know if there are more specific instructions/guidelines for making a PR. |
fixed by #5013 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
in
core/util.py
we got:but since pandas 1.3
ABCIndexClass
isABCIndex
:https://github.com/pandas-dev/pandas/blame/f00ed8f47020034e752baf0250483053340971b0/pandas/core/dtypes/generic.py#L92
This little change leads to this monstrous traceback trying to do a hvplot on an xarray:
How about adding another version edge-case:
So, https://github.com/holoviz/holoviews/blob/master/holoviews/core/util.py#L47-L55
becomes:
This has become quite ugly already, I wonder what methods are there (being no computer scientist), to avoid these issues? An API that would stay the same and the API would remap any refactors? That might only be possible to some extent, right?
The text was updated successfully, but these errors were encountered: