Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callable argspec validation should allow kwargs for kdim arguments #2318

Closed
philippjfr opened this issue Feb 8, 2018 · 2 comments
Closed
Labels

Comments

@philippjfr
Copy link
Member

When writing DynamicMap callbacks you sometimes want to write a general callback which will work with different numbers of key dimensions. Currently the Callable argspec validation completely prevents this because each key dimension needs to be explicitly named in the callback signature. This makes it completely impossible (or at least very painful) to write a library level callback that handles different numbers of dimensions. I'd very strongly argue that using kwargs should lift the restrictions on validation as it already does for stream parameters.

@jlstevens
Copy link
Contributor

jlstevens commented Feb 8, 2018

I am happy to change policy so this style is not disallowed. It makes validation weaker when used so I in turn would strongly recommend not using this style unless necessary. But I do agree we shouldn't disallow it.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants