-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background no longer transparent #1051
Comments
This might be a red herring, but that looks suspiciously like the output from my currently open PR. Is there any way the docs build could be using the wrong branch? |
The blueness was not present in the documentation for version 0.7.0 but it is there in version 0.11.1. The This could be related to some changes made on these lines: datashader/datashader/transfer_functions/__init__.py Lines 218 to 226 in 11a1924
A guess would be this PR #910. |
Following on from @hoxbro's comment, if you change the line if data.dtype.kind == 'u': to if data.dtype.kind in ('u', 'i'): then this renders correctly and |
Based on #910 (comment), I will say it was chosen to work this way - if this is still the case, I don't know. If it is still the case, I suggest adding an argument to |
It was definitely not intended that the background ever show up blue like that. :-) So that's an unintentional implication of an intentional change. For floats, we are using NaN to represent missing data, i.e., the absence of any values. For an integer count, 0 is the absence of values, so 0 as NaN makes sense for count. But for a sum of integers, there could be negative numbers where the result is zero even though there is data, and in that case we can't treat 0 as no data. So I don't think it's safe to do The two cases where I can see this behavior in the docs are:
Maybe best just to fix it in the docs? |
Datashader 0.13 and master both show a background from the colormap, rather than letting the page background show through, in certain cases that used to work fine. E.g. the current Datashader docs show:
Here the background should have been (and used to be) NaN or zero in a way that renders to an alpha value of zero in the background, letting the page show through.
The text was updated successfully, but these errors were encountered: