Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Stdin #389

Open
jeffmccune opened this issue Dec 20, 2024 · 1 comment
Open

Component Stdin #389

jeffmccune opened this issue Dec 20, 2024 · 1 comment

Comments

@jeffmccune
Copy link
Contributor

jeffmccune commented Dec 20, 2024

Pass core.Component via standard input from holos render platform to holos render component

Reasons to do this:

  1. Easier to maintain, the struct is kept in sync on both sides of the process. Don't need to wire up new flags every time we add a new field.
  2. Comprehensive unity tests. Take the Platform spec output, create one testscript case for every item in the components list.
@jeffmccune jeffmccune added this to Board Dec 19, 2024
@jeffmccune jeffmccune converted this from a draft issue Dec 20, 2024
@jeffmccune
Copy link
Contributor Author

#391 is another case where it could have been a quick thing to implement, but ended up taking a lot more time since we'd need to wire experiments through flags from holos render platform to holos render component.

The development slow down comes from two main places:

  1. wiring up flags
  2. holow show platform behaves differently

Ideally when we solve this we define a protocol to pass a core.Component, then wrap that core.Component in a builder.Component which should ideally take on more of the responsiblity of constructing the cue context in a consistent way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant