Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow unicode names #232

Open
futurist opened this issue Dec 27, 2016 · 1 comment
Open

allow unicode names #232

futurist opened this issue Dec 27, 2016 · 1 comment

Comments

@futurist
Copy link

According to the spec, unicode can be appeared in names, but below check prevent that

https://github.com/holidayextras/jsonapi-server/blob/master/lib/jsonApi.js#L57

The unicode world need this feature, could add unicode support?

@theninj4
Copy link
Contributor

The spec says:

The following “globally allowed characters” MAY be used anywhere in a member name:
...
U+0080 and above (non-ASCII Unicode characters; not recommended, not URL safe)

So whilst they're not recommended, we could have a config setting that enables engineers to opt-in to say "Yes, these characters aren't URL safe, but I have no choice" and therefore loosen our validation regexp's.

I wonder how things like Swagger and GraphQL deal with unicode characters...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants