Feature/0002 more typings #5
Conversation
src/types/JobParameters.ts
Outdated
| @@ -6,13 +6,12 @@ export interface IJobParameters<DATA = unknown | void> { | |||
|
|
|||
| name: string; | |||
| priority: number; | |||
| nextRunAt: Date | null; | |||
| nextRunAt?: Date | null; | |||
There was a problem hiding this comment.
now | null can be reverted again right?
There was a problem hiding this comment.
We never $unset nextRunAt and there are multiple places where nextRunAt is set explicitly to null
The reason to make nextRunAt optional was the delete of nextRunAt in line 297 in JobDbRepository.ts
There was a problem hiding this comment.
ah right nextRunAt: Date | null;
there is .toJson() used (which is kinda weird anyway), but the reason behind this is that it returned a partial result before, you have changed the result of it to a non partial return value, what was the motivation behind that? Could we just let it return a partial result? Otherwise we could also just change line 252 to:
from ...job.toJson() to ...(job.toJson() as Partial<IJobParameters>),
There was a problem hiding this comment.
I reverted that ? making nextRunAt mandatory in typings. I changed in line 297 of JobDbRepository.ts the typing when deleting that field. This makes imho the most sense.
fix: ensure type declarations are in build
second try