more typings, minor functionality changes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2020 19:06
remoev unnused file
fix unit test
simllll
reviewed
Oct 20, 2020
| async unlockJob(job) { | ||
| await this.collection.updateOne({ _id: job._id }, { $unset: { lockedAt: true } }); | ||
| async unlockJob(job: Job): Promise<void> { | ||
| await this.collection.updateOne({ _id: job.attrs._id }, { $unset: { lockedAt: true } }); |
There was a problem hiding this comment.
nice catch, we should add a test to cover successful unlocking
MeySalehi
pushed a commit
to MeySalehi/agenda
that referenced
this pull request
Jun 12, 2024
deps: update deps with `npm audit fix`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are just a few functionality changes