Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: New note with ':' causes failure #86

Closed
derekslenk opened this issue Apr 5, 2024 · 3 comments
Closed

Bug: New note with ':' causes failure #86

derekslenk opened this issue Apr 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@derekslenk
Copy link

Noticed this when pasting a key:value pair into a note. It appears that anything with a : cause the note to try and use it as a URL, and when it finally gives up (Crawling job failed: {}) it just shows: Failed to fetch link content ...

When trying to open the note, it tries to browse to key:value in my browser.

@derekslenk derekslenk changed the title New note with ':' causes failure Bug: New note with ':' causes failure Apr 5, 2024
@MohamedBassem MohamedBassem added the bug Something isn't working label Apr 5, 2024
@MohamedBassem
Copy link
Collaborator

Oh that's a good catch. I think I'll enforce that URLs must have a protocol in them (e.g. https:// or http://) for them to be considered as URLs I guess.

@derekslenk
Copy link
Author

I wasn't trying to paste a URL, that is the problem. It was a note with JUST a key:value entry.

I have been doing some testing, and it only occurs if the : is directly after the first work (or maybe before the first space?).

For example, look: broken breaks it.

But if I do look here: not broken, it works fine.

Hope that clears it up

@MohamedBassem
Copy link
Collaborator

Yeah, I managed to repro and already have a fix that will be available in the next release. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants