Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support vs getInitialProps or document middleware #4

Closed
hoangvvo opened this issue Oct 15, 2019 · 0 comments · Fixed by #11
Closed

Add support vs getInitialProps or document middleware #4

hoangvvo opened this issue Oct 15, 2019 · 0 comments · Fixed by #11
Assignees
@hoangvvo
Labels
feature Adding or requesting core feature
Milestone
1.0.0

Comments

@hoangvvo
Copy link
Owner

Currently, next-connect works with API Routes only.

We need to add support for getInitialProps or better yet document middleware (vercel/next.js#7208). They both share the same PageContext and can be implemented with one same approach.

Current implementation of nextConnect() returns a function with two argument. It is possible to approach it with withMiddleware() or useMiddleware() as in next-session.
@hoangvvo hoangvvo added the feature Adding or requesting core feature label Oct 15, 2019
@hoangvvo hoangvvo added this to the 1.0.0 milestone Oct 15, 2019
@hoangvvo hoangvvo self-assigned this Oct 15, 2019
@hoangvvo hoangvvo mentioned this issue Oct 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoangvvo hoangvvo

Labels
feature Adding or requesting core feature
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Add support for non-api pages hoangvvo/next-connect
1 participant
@hoangvvo