From b10533125584fa3c110061e0b7745bbc51ba2ec5 Mon Sep 17 00:00:00 2001
From: fazanki <fazanki@gmail.com>
Date: Tue, 11 Dec 2018 16:12:16 +0000
Subject: [PATCH] commits as per pr comments

---
 .../components/header/header.component.html       |  7 ++-----
 .../domain/components/header/header.component.ts  | 15 +++++++++++++--
 .../search-result/search-result.component.ts      |  2 --
 .../pages/view-case/view-case.component.ts        |  2 +-
 4 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/src/app/domain/components/header/header.component.html b/src/app/domain/components/header/header.component.html
index 94bcb0f61..7f66a3dd7 100644
--- a/src/app/domain/components/header/header.component.html
+++ b/src/app/domain/components/header/header.component.html
@@ -1,4 +1,5 @@
 <header>
+    <!--TODO move the json file to TS file-->
     <app-hmcts-global-header [serviceName]="{
         name: 'Judicial case manager',
         url: '/'
@@ -10,9 +11,5 @@
         }]
     }" ></app-hmcts-global-header>
 
-    <app-hmcts-primary-navigation [label]="" [items]="[{
-        text: 'Your cases',
-        href: '/',
-        active: true
-    }]"></app-hmcts-primary-navigation>
+    <app-hmcts-primary-navigation [label]="" [items]="navItems"></app-hmcts-primary-navigation>
 </header>
diff --git a/src/app/domain/components/header/header.component.ts b/src/app/domain/components/header/header.component.ts
index 43cb370ed..018f68c37 100644
--- a/src/app/domain/components/header/header.component.ts
+++ b/src/app/domain/components/header/header.component.ts
@@ -1,15 +1,26 @@
-import {Component} from '@angular/core';
+import {Component, OnInit} from '@angular/core';
 import {AuthService} from '../../../auth/auth.service';
 @Component({
     selector: 'app-header',
     templateUrl: './header.component.html',
     styleUrls: ['./header.component.scss']
 })
-export class HeaderComponent {
+export class HeaderComponent implements  OnInit {
 
     logoutLink: string;
+    navItems: Array<{}>;
 
     constructor(public authService: AuthService) {
         this.logoutLink = `/logout?redirect=${encodeURIComponent(this.authService.generateLoginUrl())}`;
     }
+
+    ngOnInit(): void {
+        this.navItems = [{
+            text: 'Your cases',
+            href: '/',
+            active: true
+        }];
+    }
+
+
 }
diff --git a/src/app/domain/components/search-result/search-result.component.ts b/src/app/domain/components/search-result/search-result.component.ts
index 8325411dd..d07bb244e 100644
--- a/src/app/domain/components/search-result/search-result.component.ts
+++ b/src/app/domain/components/search-result/search-result.component.ts
@@ -19,6 +19,4 @@ export class SearchResultComponent implements OnInit {
     ngOnInit() {
         this.data$ = this.caseService.search();
     }
-
-    onSubmit() {}
 }
diff --git a/src/app/routing/pages/view-case/view-case.component.ts b/src/app/routing/pages/view-case/view-case.component.ts
index cce5517ad..bb339c749 100644
--- a/src/app/routing/pages/view-case/view-case.component.ts
+++ b/src/app/routing/pages/view-case/view-case.component.ts
@@ -51,7 +51,7 @@ export class ViewCaseComponent implements OnInit, OnDestroy {
             }
         }
     }
-    private setNavigationSections() {
+    private setNavigationSections(): void {
         this.sections = this.caseDataService.getNavigation(this.case, this.sectionTabName);
     }