Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accordion] load smaller images #109

Closed
mhaack opened this issue Mar 23, 2023 · 3 comments
Closed

[Accordion] load smaller images #109

mhaack opened this issue Mar 23, 2023 · 3 comments
Assignees
@paolomoz
Labels
bug Something isn't working frontend

Comments

@mhaack
Copy link
Contributor

mhaack commented Mar 23, 2023

See LHS screenshot, we don't need images with width=2000 here.

Screenshot 2023-03-23 at 09 39 26
@mhaack mhaack added bug Something isn't working frontend labels Mar 23, 2023
@paolomoz paolomoz self-assigned this Mar 23, 2023
@paolomoz
Copy link
Collaborator

@mhaack based on my research Google is testing 412px screen. Franklin default breakpoint is 400px. IMO there could be an opportunity of aligning Franklin default breakpoint with PageSpeed, but not worth it at project level

@paolomoz paolomoz closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
@paolomoz
Copy link
Collaborator

This will be fixed in the Franklin pipeline by adobe/helix-html-pipeline#280

@paolomoz paolomoz reopened this Mar 31, 2023
@paolomoz
Copy link
Collaborator

Fixed in Franklin pipeline adobe/helix-html-pipeline#280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paolomoz paolomoz

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paolomoz @mhaack