Moves common setup and teardown for tests into fixture

Author: hlapp

test/01.js

@@ -2,61 +2,30 @@
 
 var test = require('tape'),
     sinon = require('sinon');
-var path = require('path');
-var embeddedStart = require('../');
-
-const REDsettings = {
-    httpAdminRoot: false,
-    httpNodeRoot: false,
-    functionGlobalContext: {},
-    disableEditor: true,
-    userDir: path.join(__dirname, '.node-red'),
-    logging: {
-        console: {
-            level: process.env.NODE_RED_LOGLEVEL || "info"
-        }
-    }
-};
+var embeddedStart = require('../'),
+    fixture = require('./fixture');
 
 var RED;
 var REDevents;
 var testFlow;
 
-function failAndEnd(t) {
-    return (err) => {
-        t.fail(err);
-        t.end();
-    };
-}
-
 test.onFinish(function() {
-
-    function closeUp() {
-        let prom = testFlow ? RED.nodes.removeFlow(testFlow) : Promise.resolve();
-        if (RED) {
-            prom = prom.then(() => RED.stop());
-        }
-        prom.catch((e) => {
-            console.error("stopping Node-RED failed:");
-            console.error(e.stack ? e.stack : e);
-        });
-    }
-
-    closeUp();
+    fixture.closeUp(RED, testFlow);
 });
 
 test('can create and initialize Node-RED runtime', function(t) {
     t.plan(3);
 
     t.doesNotThrow(() => {
         RED = require('node-red');
-    }, undefined, 'instantiates Node-RED runtime without error');
-    t.doesNotThrow(RED.init.bind(RED, undefined, REDsettings),
-                   undefined,
-                   'initializes Node-RED runtime without error');
+    }, undefined, 'loads Node-RED module without error');
+    t.doesNotThrow(
+        RED.init.bind(RED, undefined, fixture.settings),
+        undefined,
+        'initializes Node-RED runtime without error');
     t.doesNotThrow(() => {
         REDevents = require('node-red/red/runtime/events');
-    }, undefined, 'loads RED events object without erorr');
+    }, undefined, 'loads Node-RED events module without error');
 });
 
 test('can be used to generate wait function', function(t) {
@@ -84,7 +53,7 @@ test('can be used to promise waiting for \'nodes-started\'', function(t) {
             spy();
             tt.pass('resolves once nodes-started event fires');
             tt.equal(result, REDresult, 'passes result through');
-        }).catch(failAndEnd(tt));
+        }).catch(fixture.failAndEnd(tt));
         setTimeout(() => {
             tt.ok(spy.notCalled, 'does not resolve before node-started event fires');
             REDevents.emit('nodes-started');
@@ -116,7 +85,7 @@ test('generated function promises to wait for \'nodes-started\'', function(t) {
         spy();
         t.pass('resolves once nodes-started event fires');
         t.equal(result, REDresult, 'passes result through');
-    }).catch(failAndEnd(t));
+    }).catch(fixture.failAndEnd(t));
     setTimeout(() => {
         t.ok(spy.notCalled, 'does not resolve before node-started event fires');
         REDevents.emit('nodes-started');
@@ -195,7 +164,7 @@ test('waiting for \'nodes-started\' results in flow API ready', function(t) {
         t.doesNotThrow(() => addFlow(t, true),
                        undefined,
                        'addFlow() now returns without error');
-    }).catch(failAndEnd(t));
+    }).catch(fixture.failAndEnd(t));
 });
 
 test('generated function resolves immediately if flows API ready', function(t) {
@@ -208,7 +177,7 @@ test('generated function resolves immediately if flows API ready', function(t) {
         spy();
         t.pass('wait function resolves immediately when flows API ready');
         t.equal(result, REDresult, 'and passes result through');
-    }).catch(failAndEnd(t));
+    }).catch(fixture.failAndEnd(t));
     setTimeout(() => {
         t.ok(spy.calledOnce, 'has resolved before timeout and without event');
     }, 10);

test/02.js

@@ -2,52 +2,20 @@
 
 var test = require('tape'),
     sinon = require('sinon');
-var path = require('path');
-var embeddedStart = require('../');
-
-const REDsettings = {
-    httpAdminRoot: false,
-    httpNodeRoot: false,
-    functionGlobalContext: {},
-    disableEditor: true,
-    userDir: path.join(__dirname, '.node-red'),
-    logging: {
-        console: {
-            level: process.env.NODE_RED_LOGLEVEL || "info"
-        }
-    }
-};
+var embeddedStart = require('../'),
+    fixture = require('./fixture');
 
 var RED;
 var REDstart;
 var testFlow;
 
-function failAndEnd(t) {
-    return (err) => {
-        t.fail(err);
-        t.end();
-    };
-}
-
 test.onFinish(function() {
-
-    function closeUp() {
-        let prom = testFlow ? RED.nodes.removeFlow(testFlow) : Promise.resolve();
-        if (RED) {
-            prom = prom.then(() => RED.stop());
-        }
-        prom.catch((e) => {
-            console.error("stopping Node-RED failed:");
-            console.error(e.stack ? e.stack : e);
-        });
-    }
-
     if (REDstart && RED.start !== REDstart) RED.start = REDstart;
-    closeUp();
+    fixture.closeUp(RED, testFlow);
 });
 
 RED = require('node-red');
-RED.init(undefined, REDsettings);
+RED.init(undefined, fixture.settings);
 
 test('can inject wait into RED.start()', function(t) {
     t.plan(6);
@@ -86,7 +54,7 @@ test('can inject wait into RED.start()', function(t) {
                        undefined,
                        'addFlow() returns without error');
         return prom;
-    }).catch(failAndEnd(t));
+    }).catch(fixture.failAndEnd(t));
 });
 
 test('arguments with which RED.start() is called are passed on', function(t) {
@@ -107,10 +75,10 @@ test('arguments with which RED.start() is called are passed on', function(t) {
         let call = stub.getCall(1);
         RED.start = funcToRestore; // should precede last test = this is async
         t.deepEqual(call.args, ["one", "two", "three"],
-             'correctly passes through multiple arguments');
+                    'correctly passes through multiple arguments');
         t.equal(call.thisValue, RED, '"this" is set to RED');
     }).catch((err) => {
         RED.start = funcToRestore;
-        failAndEnd(t)(err);
+        fixture.failAndEnd(t)(err);
     });
 });

test/fixture.js

@@ -0,0 +1,35 @@
+"use strict";
+
+var path = require('path');
+
+module.exports = {
+    failAndEnd: function(test) {
+        return (err) => {
+            if (err && err.stack) console.error(err.stack);
+            test.fail(err);
+            test.end();
+        };
+    },
+    closeUp: function(RED, flow) {
+        let prom = flow ? RED.nodes.removeFlow(flow) : Promise.resolve();
+        if (RED) {
+            prom = prom.then(() => RED.stop());
+        }
+        prom.catch((e) => {
+            console.error("stopping Node-RED failed:");
+            console.error(e.stack ? e.stack : e);
+        });
+    },
+    settings: {
+        httpAdminRoot: false,
+        httpNodeRoot: false,
+        functionGlobalContext: {},
+        disableEditor: true,
+        userDir: path.join(__dirname, '.node-red'),
+        logging: {
+            console: {
+                level: process.env.NODE_RED_LOGLEVEL || "info"
+            }
+        }
+    }
+};