Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using em instead rem #1

Closed
alekspetrov opened this issue Sep 27, 2014 · 11 comments
Closed

Using em instead rem #1

alekspetrov opened this issue Sep 27, 2014 · 11 comments
Assignees

Comments

@alekspetrov
Copy link

First of all thx for your work it's very usefull.
How about em? Can I re-config Gridlover to use em instead rem?

@hiulit
Copy link
Owner

hiulit commented Sep 29, 2014

Thanks for the appreciation! I'm glad you find it useful.
About adding em support, yeah, why not. I didn't think of it because I personally don't use them that much, but the Gridlover app uses them and since this is kind of a "Sass port" of their app, it would be consistent to add support to ems.
What I think would be the best approach, would be to let the users decide which unit they'd like to output. For example:

  • px
  • rem
  • px/rem (rems with pixels fallback)
  • em

This could be achieved via variables, as it is working right now with the rem support. What do you think?
I could try and give it a try this week. But if you would like to help, don't hesitate!
Thanks!

@alekspetrov
Copy link
Author

Oh, It maybe a wrong question, I asked how to re-config it for ems ) cause I need flexible config for project and I don't want to change my setup with the GridLover.app. I'll see it later, have no free time now.

@hiulit
Copy link
Owner

hiulit commented Oct 2, 2014

Hi,
I've been trying to add em support but I haven't been successful due to the relativity of ems. I can't figure out the way to do it...
I've created a branch for testing em support https://github.com/hiulit/Sassy-Gridlover/tree/em-support

@alekspetrov
Copy link
Author

Yea, first time I tried to replace rem by em and that was the reason to make an issue =) cause output was another size.

I think all calculations have to be in px val, then translate the output into em or any other vals. It gives more flexible config for the future, for example if somebody want to support vh or vw.

@hiulit
Copy link
Owner

hiulit commented Oct 6, 2014

I've been in contact with the Gridlover app team and we'll try to figure it out.

@alekspetrov
Copy link
Author

Great, let me know.

@cibulka
Copy link

cibulka commented Oct 9, 2014

+1!

@hiulit hiulit self-assigned this Oct 16, 2014
@hiulit
Copy link
Owner

hiulit commented Nov 16, 2014

Quick update. I've been in contact with one of the Gridlover developers but unfortunately neither of us have the time right now to take a deep look into this matter. So any help is extra welcome :)

@hiulit
Copy link
Owner

hiulit commented Mar 5, 2015

There's a branch for this issue https://github.com/hiulit/Sassy-Gridlover/tree/em-support

@hiulit
Copy link
Owner

hiulit commented Apr 30, 2015

Good news everyone!

@walmokrani help a lot with this issue #7. I have to take a look at it so I can merge it. But it's looking good :D

@hiulit
Copy link
Owner

hiulit commented Nov 10, 2015

Hey guys @alekspetrov @cibulka !
I've just released v2.0.0 with em support! Check it out and tell me what you think or if it works for you! ;)

Thanks again to @walmokrani !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants