Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Certificate in Vault is also generated or copied even if flag in configuration tls_disable is set to true #1412

Closed
erzetpe opened this issue Jul 2, 2020 · 1 comment · Fixed by #1434
Closed

[BUG] Certificate in Vault is also generated or copied even if flag in configuration tls_disable is set to true #1412

erzetpe opened this issue Jul 2, 2020 · 1 comment · Fixed by #1434
Assignees
@erzetpe @przemyslavic
Labels
area/vault type/bug
Milestone
S20200729

Comments

@erzetpe
Copy link
Contributor

erzetpe commented Jul 2, 2020 •
edited
Loading

Describe the bug
Certificate in Vault is also generated or copied even if flag in configuration tls_disable is set to true in Vault configuration.

To Reproduce
Steps to reproduce the behavior:

  1. Create Vault config in Epiphany configuration, e.g:
---
kind: configuration/vault
title: Vault Config
provider: aws
name: default
specification:
  vault_enabled: true
  tls_disable: true
  1. Execute epicli apply ... with your configuration file and settings from abov

Expected behavior
With flag tls_disable set to true part of code related to certificates should be skipped.

Config files
Shown above.

OS (please complete the following information):

  • OS: All

Cloud Environment (please complete the following information):

  • Cloud Provider: All

Additional context
No any additional context.
@erzetpe erzetpe self-assigned this Jul 2, 2020
@erzetpe erzetpe added this to the 0.7.1 milestone Jul 2, 2020
@erzetpe erzetpe changed the title [BUG] Short description of the bug [BUG] Certificate in Vault is also generated or copied even if flag in configuration tls_disable is set to true Jul 2, 2020
@erzetpe erzetpe mentioned this issue Jul 10, 2020
Merged
@erzetpe erzetpe linked a pull request Jul 10, 2020 that will close this issue
Fix issue with Vault and Kubernetes Calico/Canal communication #1434
Merged
@mkyc mkyc reopened this Jul 13, 2020
@mkyc mkyc modified the milestones: 0.7.1, S20200729 Jul 17, 2020
@przemyslavic przemyslavic self-assigned this Jul 21, 2020
@przemyslavic
Copy link
Collaborator

It has been tested. The certificate generation/copying now depends on the value of the tls_disable parameter.

@toszo toszo closed this as completed Aug 4, 2020
@seriva seriva mentioned this issue Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erzetpe erzetpe

@przemyslavic przemyslavic

Labels
area/vault type/bug
Projects
None yet
Milestone
S20200729
Development

Successfully merging a pull request may close this issue.

Fix issue with Vault and Kubernetes Calico/Canal communication erzetpe/epiphany
4 participants
@erzetpe @toszo @mkyc @przemyslavic