Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: persist user selected theme #2791

Closed
wants to merge 2 commits into from
Closed

fix: persist user selected theme #2791

wants to merge 2 commits into from

Conversation

edu-stx
Copy link
Contributor

@edu-stx edu-stx commented Nov 3, 2022 •
edited by github-actions bot
Loading

Try out this version of the Hiro Wallet - download extension builds.

With this fix, the theme setting selected by users will persist across sessions.

@vercel vercel bot temporarily deployed to Preview November 3, 2022 14:33 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from e492ecd to 2eeb486 Compare November 3, 2022 14:46
@vercel vercel bot temporarily deployed to Preview November 3, 2022 14:46 Inactive
@edu-stx edu-stx requested review from kyranjamie and fbwoolf November 3, 2022 14:47
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch 2 times, most recently from ccda273 to 0d5f8bf Compare November 3, 2022 16:50
@vercel vercel bot temporarily deployed to Preview November 3, 2022 16:51 Inactive
fbwoolf
fbwoolf reviewed Nov 3, 2022
View reviewed changes
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from 0d5f8bf to da1aa4c Compare November 3, 2022 18:08
@vercel vercel bot temporarily deployed to Preview November 3, 2022 18:09 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from da1aa4c to 214f68e Compare November 3, 2022 18:09
@vercel vercel bot temporarily deployed to Preview November 3, 2022 18:10 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from 214f68e to e3c24ab Compare November 3, 2022 19:06
@vercel vercel bot temporarily deployed to Preview November 3, 2022 19:07 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from e3c24ab to 1de48e6 Compare November 3, 2022 19:08
@vercel vercel bot temporarily deployed to Preview November 3, 2022 19:09 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from 1de48e6 to 43014b7 Compare November 3, 2022 19:11
@vercel vercel bot temporarily deployed to Preview November 3, 2022 19:12 Inactive
@edu-stx edu-stx mentioned this pull request Nov 3, 2022
Merged
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from 43014b7 to ac56729 Compare November 4, 2022 14:14
@vercel vercel bot temporarily deployed to Preview November 4, 2022 14:15 Inactive
@vercel vercel bot temporarily deployed to Preview November 4, 2022 14:54 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from 6bd3c24 to cd8cd2b Compare November 4, 2022 15:03
@vercel vercel bot temporarily deployed to Preview November 4, 2022 15:04 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch 2 times, most recently from 400825a to d867a71 Compare November 4, 2022 15:44
@vercel vercel bot temporarily deployed to Preview November 4, 2022 15:45 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from d867a71 to 8cd0f21 Compare November 4, 2022 16:55
@vercel vercel bot temporarily deployed to Preview November 4, 2022 16:56 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from 8cd0f21 to dceeeb2 Compare November 4, 2022 17:16
@vercel vercel bot temporarily deployed to Preview November 4, 2022 17:17 Inactive
@edu-stx edu-stx force-pushed the fix/Theme-setting-lost-between-sessions-#2789 branch from dceeeb2 to f5f2200 Compare November 4, 2022 17:41
@vercel vercel bot temporarily deployed to Preview November 4, 2022 17:42 Inactive
@fbwoolf
Copy link
Contributor

fbwoolf commented Nov 4, 2022

@edu-stx I cherry-picked your commit and pushed up a fresh branch to test. All tests pass in the PR! Super weird. 🤔
#2804

@edu-stx
Copy link
Contributor Author

edu-stx commented Nov 5, 2022

Thanks @fbwoolf! Let's use that one. Closing this one.

@edu-stx edu-stx closed this Nov 5, 2022
@edu-stx edu-stx mentioned this pull request Nov 9, 2022
Closed
@edu-stx edu-stx deleted the fix/Theme-setting-lost-between-sessions-#2789 branch December 6, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbwoolf fbwoolf fbwoolf left review comments

@kyranjamie kyranjamie Awaiting requested review from kyranjamie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edu-stx @fbwoolf @kyranjamie