Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: other empty result responses #1915

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: other empty result responses #1915

merged 1 commit into from
Mar 28, 2024

Conversation

rafaelcr
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count or length?

Copy link

Vercel deployment URL: https://stacks-blockchain-ri01z3b42-blockstack.vercel.app 🚀

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.87%. Comparing base (a7a4558) to head (61f5d58).
Report is 1 commits behind head on nakamoto.

Additional details and impacted files
@@             Coverage Diff              @@
##           nakamoto    #1915      +/-   ##
============================================
+ Coverage     71.96%   72.87%   +0.90%     
============================================
  Files            94       94              
  Lines         12409    12411       +2     
  Branches       2854     2857       +3     
============================================
+ Hits           8930     9044     +114     
+ Misses         3308     3206     -102     
+ Partials        171      161      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaelcr
Copy link
Collaborator Author

@janniks count is a property added by postgres.js that returns the number of resulting rows 👍

Copy link
Collaborator

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 🫡

@rafaelcr rafaelcr merged commit 3cd2c64 into nakamoto Mar 28, 2024
27 of 31 checks passed
@rafaelcr rafaelcr deleted the fix/empty-results branch March 28, 2024 16:09
blockstack-devops pushed a commit that referenced this pull request Mar 28, 2024
## [7.10.0-nakamoto.4](v7.10.0-nakamoto.3...v7.10.0-nakamoto.4) (2024-03-28)

### Bug Fixes

* other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.10.0-nakamoto.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Apr 9, 2024
## [7.10.0-beta.2](v7.10.0-beta.1...v7.10.0-beta.2) (2024-04-09)

### Features

* add nakamoto block time to v2 endpoints ([#1921](#1921)) ([ae6bbe8](ae6bbe8))
* rosetta pox4 stacking support ([#1928](#1928)) ([2ba36f9](2ba36f9)), closes [#1929](#1929)

### Bug Fixes

* add nakamoto testnet to openapi docs ([#1910](#1910)) ([01fb971](01fb971))
* batch drop mempool transactions ([#1920](#1920)) ([a7ee96d](a7ee96d))
* batch drop mempool transactions ([#1920](#1920)) ([#1927](#1927)) ([f522d79](f522d79))
* cycle signer filter ([#1916](#1916)) ([dc7d600](dc7d600))
* cycles response for empty cycle info ([#1914](#1914)) ([a7a4558](a7a4558))
* other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.10.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Apr 15, 2024
## [7.10.0](v7.9.1...v7.10.0) (2024-04-15)

### Features

* add nakamoto block time to v2 endpoints ([#1921](#1921)) ([ae6bbe8](ae6bbe8))
* add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23))
* ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f))
* nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832))
* pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849)
* pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805))
* rosetta pox4 stacking support ([#1928](#1928)) ([2ba36f9](2ba36f9)), closes [#1929](#1929)

### Bug Fixes

* add nakamoto testnet to openapi docs ([#1910](#1910)) ([01fb971](01fb971))
* batch drop mempool transactions ([#1920](#1920)) ([a7ee96d](a7ee96d))
* cycle signer filter ([#1916](#1916)) ([dc7d600](dc7d600))
* cycles response for empty cycle info ([#1914](#1914)) ([a7a4558](a7a4558))
* delegate-stx burn-op parsing and test fix ([#1939](#1939)) ([73ec0db](73ec0db))
* event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73))
* log message when sql migration is performed ([#1942](#1942)) ([49a4d25](49a4d25))
* other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64))
* pox4 stack-stx burn-op handling ([#1936](#1936)) ([9e9a464](9e9a464))
* remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b))
* sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Apr 15, 2024
## [7.10.0-beta.1](v7.9.1...v7.10.0-beta.1) (2024-04-15)

### Features

* add nakamoto block time to v2 endpoints ([#1921](#1921)) ([ae6bbe8](ae6bbe8))
* add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23))
* ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f))
* nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832))
* pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849)
* pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805))
* rosetta pox4 stacking support ([#1928](#1928)) ([2ba36f9](2ba36f9)), closes [#1929](#1929)
* support multiple STX faucet source accounts ([#1946](#1946)) ([5d69c7c](5d69c7c))

### Bug Fixes

* add nakamoto testnet to openapi docs ([#1910](#1910)) ([01fb971](01fb971))
* batch drop mempool transactions ([#1920](#1920)) ([a7ee96d](a7ee96d))
* cycle signer filter ([#1916](#1916)) ([dc7d600](dc7d600))
* cycles response for empty cycle info ([#1914](#1914)) ([a7a4558](a7a4558))
* delegate-stx burn-op parsing and test fix ([#1939](#1939)) ([73ec0db](73ec0db))
* event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73))
* log message when sql migration is performed ([#1942](#1942)) ([49a4d25](49a4d25))
* other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64))
* pox4 stack-stx burn-op handling ([#1936](#1936)) ([9e9a464](9e9a464))
* remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b))
* sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants