Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flakiness with pox-4-btc-address-formats tests #1849

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

zone117x
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffe0502) 17.72% compared to head (a777825) 71.89%.
Report is 1 commits behind head on feat/pox-4-revoke-events.

❗ Current head a777825 differs from pull request most recent head 33b5213. Consider uploading reports for the commit 33b5213 to get more accurate results

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/pox-4-revoke-events    #1849       +/-   ##
=============================================================
+ Coverage                     17.72%   71.89%   +54.17%     
=============================================================
  Files                            92       92               
  Lines                         11907    11907               
  Branches                       2624     2624               
=============================================================
+ Hits                           2110     8561     +6451     
+ Misses                         9115     3193     -5922     
+ Partials                        682      153      -529     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 25, 2024

Vercel deployment URL: https://stacks-blockchain-lrkml8jqt-blockstack.vercel.app 🚀

@zone117x zone117x force-pushed the fix/pox-btc-addrs-flake branch from a777825 to 33b5213 Compare January 25, 2024 21:40
@zone117x zone117x marked this pull request as ready for review January 25, 2024 21:42
@zone117x zone117x requested a review from janniks January 25, 2024 21:42
@zone117x zone117x merged commit ab363ef into feat/pox-4-revoke-events Jan 25, 2024
53 of 57 checks passed
@zone117x zone117x deleted the fix/pox-btc-addrs-flake branch January 25, 2024 21:47
Copy link
Collaborator

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zone117x added a commit that referenced this pull request Jan 25, 2024
* fix: add pox-4 event tests

* test: fix pox-4 revoke test

* chore: remove unused param from synthetic event

* test: add signer-keys

* test: add more signer-keys

* chore: update to beta stacking client

* test: fix single test

* test: refactor btc address format stacking with bitcoin rpc

* test: fix pox-4-stack-extend-increase

* fix: update rosetta to use signer-key

* build: add generated docs

* test: fix rosetta test

* fix: update to latest node image

* chore: bump latest stacks-node image

* fix(test): update arg ordering for delegate-stack-extend

* fix(test): update arg ordering for delegate-stack-extend

* test: revert size change for delegate-stx action

* test: skip broken burnchain op test

* test: unflake timing of pox test with reward slots

* chore: update test helper, since current_cycle.id can be incorrect

* test: fix btc address test

* test: add timing tolerance on unlock tests

* test: add timing tolerance on reward test

* test: allow multiple rewards

* test: allow multiple rewards

* fix: add migration for pox-4

* chore: undo beta version of stackingclient

* ci: do not require epoch2.5 tests to pass for now, too flaky

* test: switch order in test

* test: fix flakiness with `pox-4-btc-address-formats` tests (#1849)

* test: fix flakiness with `pox-4-btc-address-formats` tests

* test: specify new bitcoin wallet name

* test: fix main bitcoin wallet private key pollution in more tests

---------

Co-authored-by: janniks <janniks@users.noreply.github.com>
Co-authored-by: Matthew Little <zone117x@gmail.com>
blockstack-devops pushed a commit that referenced this pull request Jan 25, 2024
## [7.9.0-nakamoto.1](v7.8.0...v7.9.0-nakamoto.1) (2024-01-25)

### Features

* pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849)
blockstack-devops pushed a commit that referenced this pull request Mar 21, 2024
## [7.10.0-nakamoto.1](v7.9.0...v7.10.0-nakamoto.1) (2024-03-21)

### Features

* add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23))
* ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f))
* nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832))
* pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849)
* pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805))

### Bug Fixes

* event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73))
* remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b))
* sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))
blockstack-devops pushed a commit that referenced this pull request Mar 21, 2024
## [7.10.0-beta.1](v7.9.0...v7.10.0-beta.1) (2024-03-21)

### Features

* add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23))
* ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f))
* nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832))
* pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849)
* pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805))

### Bug Fixes

* event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73))
* remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b))
* sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))
blockstack-devops pushed a commit that referenced this pull request Apr 15, 2024
## [7.10.0](v7.9.1...v7.10.0) (2024-04-15)

### Features

* add nakamoto block time to v2 endpoints ([#1921](#1921)) ([ae6bbe8](ae6bbe8))
* add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23))
* ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f))
* nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832))
* pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849)
* pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805))
* rosetta pox4 stacking support ([#1928](#1928)) ([2ba36f9](2ba36f9)), closes [#1929](#1929)

### Bug Fixes

* add nakamoto testnet to openapi docs ([#1910](#1910)) ([01fb971](01fb971))
* batch drop mempool transactions ([#1920](#1920)) ([a7ee96d](a7ee96d))
* cycle signer filter ([#1916](#1916)) ([dc7d600](dc7d600))
* cycles response for empty cycle info ([#1914](#1914)) ([a7a4558](a7a4558))
* delegate-stx burn-op parsing and test fix ([#1939](#1939)) ([73ec0db](73ec0db))
* event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73))
* log message when sql migration is performed ([#1942](#1942)) ([49a4d25](49a4d25))
* other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64))
* pox4 stack-stx burn-op handling ([#1936](#1936)) ([9e9a464](9e9a464))
* remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b))
* sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))
blockstack-devops pushed a commit that referenced this pull request Apr 15, 2024
## [7.10.0-beta.1](v7.9.1...v7.10.0-beta.1) (2024-04-15)

### Features

* add nakamoto block time to v2 endpoints ([#1921](#1921)) ([ae6bbe8](ae6bbe8))
* add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23))
* ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f))
* nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832))
* pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849)
* pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805))
* rosetta pox4 stacking support ([#1928](#1928)) ([2ba36f9](2ba36f9)), closes [#1929](#1929)
* support multiple STX faucet source accounts ([#1946](#1946)) ([5d69c7c](5d69c7c))

### Bug Fixes

* add nakamoto testnet to openapi docs ([#1910](#1910)) ([01fb971](01fb971))
* batch drop mempool transactions ([#1920](#1920)) ([a7ee96d](a7ee96d))
* cycle signer filter ([#1916](#1916)) ([dc7d600](dc7d600))
* cycles response for empty cycle info ([#1914](#1914)) ([a7a4558](a7a4558))
* delegate-stx burn-op parsing and test fix ([#1939](#1939)) ([73ec0db](73ec0db))
* event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73))
* log message when sql migration is performed ([#1942](#1942)) ([49a4d25](49a4d25))
* other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64))
* pox4 stack-stx burn-op handling ([#1936](#1936)) ([9e9a464](9e9a464))
* remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b))
* sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants