Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owner field to 'geosearch for bots' API #573

Closed
bengtan opened this issue Mar 17, 2017 · 2 comments
Closed

Add owner field to 'geosearch for bots' API #573

bengtan opened this issue Mar 17, 2017 · 2 comments
Assignees

Comments

@bengtan
Copy link
Contributor

bengtan commented Mar 17, 2017

We need to add 'owner' to avoid extra request for each bot to retrieve owner.

hippware/rn-chat#397 (comment)


Bonus point: Any other bot fields we are omitting? Maybe we should consider returning the entire bot 'object'?

@toland
Copy link
Contributor

toland commented Mar 17, 2017

We are currently indexing server, title, image, lat, lon, and radius.

When adding fields we need to decide if the fields should be available for searching or only via the returned object.

Adding the owner field is a one-line change to the code and a simple update the the Algolia indices.

@aksonov Are there any other fields you need while I am in there?

@aksonov
Copy link

aksonov commented Mar 17, 2017 via email

@bengtan bengtan closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants