Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback 30 second debounce rule needs more data points #1946

Closed
bengtan opened this issue Oct 19, 2018 · 4 comments
Closed

Fallback 30 second debounce rule needs more data points #1946

bengtan opened this issue Oct 19, 2018 · 4 comments
Assignees

Comments

@bengtan
Copy link
Contributor

bengtan commented Oct 19, 2018

(Note this is more of a client side topic but I'm posting it here so it can be sub-listed under #1713.)

We've made some changes/improvements/shortcuts since #1713 was posted and whilst they have been improvements, the '30 second' debounce rule still kicks in occasionally ... which is fair enough because it's the fallback 'default' rule to apply when nothing else better is available.

Over the last couple of months, we've had some instances where the '30 second' debounce rule and it's shortcomings have been noticeable. Two that have been documented:

  1. https://hippware.slack.com/archives/C2V6L53TQ/p1538555207000100 which points to
    App not updating users location with app closed rn-chat#2508 (comment) part B

  2. https://hippware.slack.com/archives/C2V6L53TQ/p1539918063000100?thread_ts=1539905662.000100&cid=C2V6L53TQ

... so I think it's time to consider client side changes so that the app will upload location data points for (up to?) 60 seconds after being stationary.

I'm not sure if such changes will be easy or difficult. That will be the next thing to consider if we agree to progress it.

@thescurry
Copy link

Beng, let's make sure this issue makes it into the next release... the "polish/bug fixes for 3.9.1" release.

@bengtan
Copy link
Contributor Author

bengtan commented Oct 23, 2018

Client side ticket:

Upload data points for a short while after being stationary
hippware/rn-chat#2984

Since this is client side work, there's no further action needed on the back-end board. However, I'll leave the ticket open for a few more days in case of any second thoughts or last minute comments.

@bengtan bengtan closed this as completed Oct 31, 2018
@bengtan
Copy link
Contributor Author

bengtan commented Nov 6, 2018

Re-opening.

Note to self: Have another look one day.

@bengtan bengtan reopened this Nov 6, 2018
@bengtan bengtan self-assigned this Nov 6, 2018
@bengtan
Copy link
Contributor Author

bengtan commented Nov 16, 2018

Closing.

#2025 and rn-chat#3036 provides us a better solution.

@bengtan bengtan closed this as completed Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants