Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked User: Location should be removed from widget without kill/reload required #2846

Closed
mstidham opened this issue Sep 21, 2018 · 9 comments
Labels
BLOCKED This issue has been blocked for some reason. BUG Code/Feature contains a known/confirmed bug

Comments

@mstidham
Copy link

Blocked User: Location should be removed from widget without kill/reload required

QA TEMPLATE Input
Device Type: iPhone 7 Plus
iOS: 11.4.1
tr Version: 3.4.2
Environment Staging
Codepush:
Internet Connection Type: WiFi
Users affected? Miranda
User handle: @miranda
Bypass handle?: @bic (123-1114)
Location access type? Always
Does this issue occur on other environments?
Time issue occurred (UTC)

Observed Result:

@miranda blocked @bic (bypass account) without killing the app the user @bic still had @miranda’s location “The Stidham Residence” on the widget. @bic tapped and does see the Oops screen but all images below are visible. Location is removed from the widget with a kill/reload.

Expected Result:

Location should be removed from the widget when a user is blocked. Kill/reload should not be required to remove location from widget.

Steps to reproduce:

  1. Block user that is in a location (location visible on widget)
  2. Location remains on the widget and is tappable.
  3. Images on Location Profile are still visible.

Related Screenshots/Video Links:


image

@mstidham mstidham added the BUG Code/Feature contains a known/confirmed bug label Sep 21, 2018
@bengtan
Copy link
Contributor

bengtan commented Sep 24, 2018

There's two symptoms here.

  1. the user @bic still had @miranda’s location “The Stidham Residence” on the widget.

  2. @bic tapped and does see the Oops screen but all images below are visible.

I'll come back to 1 later.

Symptom 2 is definitely a bug. Should be reasonably reasonable to hide all the images and stuff (even if already cached on the client) if the parent Bot/Location isn't loadable/viewable.

As for 1 ... I'm not sure if it's important enough to squeeze into the App Store release.

Maybe we can spin out 1 and 2, and leave 1 for another time? Probably needs more discussion.

@aksonov
Copy link
Contributor

aksonov commented Sep 25, 2018

I've fixed #2 as part of #2825.

@bengtan
Copy link
Contributor

bengtan commented Sep 26, 2018

@scurry:

Can we punt 1 until later?

To fix it, we'd need to implement 'live updates' for blocked users (on server and client side), and I don't think it's important enough to delay the release for.

@aksonov aksonov added the BLOCKED This issue has been blocked for some reason. label Oct 5, 2018
@aksonov
Copy link
Contributor

aksonov commented Oct 10, 2018

Bump

@southerneer
Copy link
Contributor

Ha! @bengtan [at]scurry is not on our team ;) Maybe @thescurry can help

@thescurry
Copy link

Yes, sorry I missed this ticket earlier. We can punt on 1 and pick it up on the polish after app store submission.

@bengtan
Copy link
Contributor

bengtan commented Oct 11, 2018

So we should only QA the second part:

@bic tapped and does see the Oops screen but all images below are visible.

@mstidham
Copy link
Author

Verified on Staging Version: 3.8.1

@mstidham
Copy link
Author

Verified on Prod Version: 3.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED This issue has been blocked for some reason. BUG Code/Feature contains a known/confirmed bug
Projects
None yet
Development

No branches or pull requests

5 participants