Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing bot Cover Images for some users #2512

Closed
mstidham opened this issue Jun 26, 2018 · 10 comments
Closed

Missing bot Cover Images for some users #2512

mstidham opened this issue Jun 26, 2018 · 10 comments
Labels
BUG Code/Feature contains a known/confirmed bug PRODUCTION This issue affects the production environment

Comments

@mstidham
Copy link

Missing Cover Images for select users

QA TEMPLATE Input
Device Type: iPhone 7 Plus
iOS: 11.4
tr Version: 2.6.8
Environment Production
Codepush:
Internet Connection Type: WiFi
Users affected? Miranda & Steve
User handle: @miranda &n @scurry
Bypass handle?:
Location access type? Always
Does this issue occur on other environments?
Time issue occurred (UTC)

Observed Result:

Issue #1:
User @scubachick created 5 bots with cover images. @miranda can see all cover images but @scurry does not see the cover images.
Issue #2:
User @jinah created 7 bots with cover images. @miranda can only see cover images on 1 of the bots. @tinyrobot and @scurry can see all of the cover images.

Expected Result:

Cover images should display for all users.

Steps to reproduce:

  1. Scroll through HS and find creation notification that is missing a cover photo
  2. Verify through another account if cover photo displays

Related Screenshots/Video Links:


snip20180626_1

image

@mstidham mstidham added BUG Code/Feature contains a known/confirmed bug PRODUCTION This issue affects the production environment labels Jun 26, 2018
@bengtan
Copy link
Contributor

bengtan commented Jun 27, 2018

Sounds very similar to #2511 and may be due to a common bug or something in the image handling code. Seems like a client side issue.

@mstidham: Are you able to reproduce this on Staging?

@mstidham
Copy link
Author

mstidham commented Jun 27, 2018

@bengtan I have not been able to reproduce this on Staging Version: 2.8.1 or 2.6.8. @thescurry I created 12 new bots on Staging (Cover #1, #2, etc.) please verify that you can see cover images on all 12.

@bengtan
Copy link
Contributor

bengtan commented Jun 29, 2018

@mstidham:

Another thing to try ... does a re-install change anything? I assume a kill/reload doesn't change anything.

If a re-install results in some images being loaded, and some other images being not loaded, that's further evidence that the app's image handling is buggy.

@mstidham
Copy link
Author

@bengtan A re-install resulted in all the images loading.

@bengtan
Copy link
Contributor

bengtan commented Jul 2, 2018

Good, thanks. Confirms it's a client side issue.

I think this behaviour has happened before in the past. Sometimes images aren't loaded due to transients like network connectivity, AWS etc., and the app doesn't retry them later.

There's probably an existing ticket for this somewhere, but I don't have it right now.

For future reference, @aksonov or @southerneer, when you guys try to reproduce this, try using Network Link Conditioner to simulate a buggy network.

@southerneer
Copy link
Contributor

Oh wow, this one's kinda old now. Has anyone repro'd this on Staging with v3.0+?

@bengtan
Copy link
Contributor

bengtan commented Aug 15, 2018

Oh wow, this one's kinda old now. Has anyone repro'd this on Staging with v3.0+?

Hand-balling to @mstidham. Have you seen this lately?

@mstidham
Copy link
Author

I haven't seen this on Staging but I don't think I will. Users are not able to see newly created locations that someone else has created. We also can't share locations at this point so I can't think of a way to test this on Staging.

@bengtan bengtan changed the title Missing Cover Images for select users Missing bot Cover Images for some users Sep 12, 2018
@southerneer
Copy link
Contributor

@thescurry what should we do with this one given the comments above?

@thescurry
Copy link

Hmmmm... I only regularly have issues on staging as it pertains to user @don's profile photo and Miranda confirmed he does not have profile photo set. We can probably close this ticket and re-open if we need to. Things have appeared very stable for me over the past few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Code/Feature contains a known/confirmed bug PRODUCTION This issue affects the production environment
Projects
None yet
Development

No branches or pull requests

4 participants