Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working if expo published #3

Closed
sidmorizon opened this issue May 21, 2019 · 15 comments
Closed

Not working if expo published #3

sidmorizon opened this issue May 21, 2019 · 15 comments

Comments

@sidmorizon
Copy link

Hi, it's working on expo start at local development, but when I build a native iOS or Android bundle as expo build:ios or expo publish, it does not working

@sidmorizon
Copy link
Author

It seems that the html file load js or css as relative path, it works when serve on local dev server, but can not reference in published bundle

@sebastianbochan
Copy link
Contributor

Hi @Zuozhuo,
Thank you for reporting about the bug. I will check it.

@r-bman
Copy link

r-bman commented Jun 10, 2019

It is my understanding that iOS webviews load local static files from an internal local webserver on port 8081. The static file requests look something like http://localhost:8081/assets/node_modules/@highcharts/highcharts-react-native/highcharts-layout/css/styles.css. The webview doesn't seem to have access to, or permission to access or execute files in the node_modules/@highcharts... directory once the App is compiled.

I have detailed a solution for ejected Apps here but I don't know how this can be applied to expo Apps.

@sebastianbochan
Copy link
Contributor

@Zuozhuo
Can you test solution of @r-bman and let us know about your results.

@sebastianbochan
Copy link
Contributor

The new version (2.0.2) has been already released.

Please test and let me know about your results.

@axelav
Copy link

axelav commented Mar 2, 2020

has this been resolved? I am using v2.1.1 and am experiencing this issue. everything worked great locally but when the app was published, I get an empty box where the highchart should render.

this really seems like something that should be mentioned in the readme. not something users find out after only after publishing their apps.

@sebastianbochan
Copy link
Contributor

Have you tried to move files to the correct path (android) -> https://github.com/highcharts/highcharts-react-native#files-are-not-loaded

@axelav
Copy link

axelav commented Mar 3, 2020

no, this was with an iOS app published with Expo and released through the Apple App Store.

@r-bman
Copy link

r-bman commented Mar 3, 2020

I tested this a little while ago but haven't had chance to comment. I was unable to get the latest version of the library working with local highcharts files on iOS using this method, which worked previously. IIRC the error I received in the webview console was something to do with CORS. I was only able to get the library working when the highcharts files are loaded from the cdn.

@axelav
Copy link

axelav commented Mar 3, 2020

@r-bman so if you loaded the files from the CDN, did it work in a published app, or just locally when developing? would it be possible for you to show your code of how you configured using the CDN? I'm unclear if it involves more than just passing the useCDN prop - ie, what is the CDN URL, which version of highcharts is this loading from CDN, etc?

@r-bman
Copy link

r-bman commented Mar 3, 2020

@axelav I haven't published an App using this library so I'm afraid I can't help you there. I think I just set the useCDN prop to true, yes. You can see what the useCDN prop does in HighchartsReactNative.js. I opted not to use this library in the end, in favour of a custom solution which is not currently published.

@axelav
Copy link

axelav commented Mar 3, 2020

@r-bman gotcha, thanks for that info!

@sebastianbochan
Copy link
Contributor

It can be related with the issue react-native-webview/react-native-webview#875, Im waiting for a feedback from users about that.

@axelav
Copy link

axelav commented Apr 3, 2020

any further info on this one?

@sebastianbochan
Copy link
Contributor

sebastianbochan commented Apr 6, 2020

At this moment all problems are combined and described here: #39 (also including some fixes/workarounds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants