Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Auto-convert PlotLines.value from datetime to POSIX timestamps #58

Closed
hcpchris opened this issue Jun 8, 2023 · 0 comments · Fixed by #62
Closed

Enhancement: Auto-convert PlotLines.value from datetime to POSIX timestamps #58

hcpchris opened this issue Jun 8, 2023 · 0 comments · Fixed by #62
Assignees
@hcpchris
Labels
enhancement New feature or request
Milestone
v.1.2.1

Comments

@hcpchris
Copy link
Collaborator

hcpchris commented Jun 8, 2023

As identified in #57 , and in alignment with the Highcharts (JS) API, the options.axes.plot_bands.PlotLine.value property expects a numeric value. Currently, if a Python datetime is supplied, it fails on type validation. However, if the datetime is converted to a POSIX timestamp it works correctly.

Therefore, it would be good for the PlotLine.value property to auto-convert datetime.datetime values to POSIX timestamps using the .timestamp() method.
@hcpchris hcpchris added the enhancement New feature or request label Jun 8, 2023
@hcpchris hcpchris added this to the v.1.2.1 milestone Jun 8, 2023
@hcpchris hcpchris self-assigned this Jun 8, 2023
This was referenced Jun 8, 2023
Closed
Closed
@hcpchris hcpchris mentioned this issue Jun 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcpchris hcpchris

Labels
enhancement New feature or request
Projects
None yet
Milestone
v.1.2.1
Development

Successfully merging a pull request may close this issue.

PR for v.1.2.1 highcharts-for-python/highcharts-core
1 participant
@hcpchris