Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue 183 (buffer overrun in sftp.RemoteFile.ReadAheadRemoteFileInputStream) #199

Merged
merged 2 commits into from
Jun 17, 2015

Conversation

bkarge
Copy link
Contributor

@bkarge bkarge commented Jun 4, 2015

proposed fix for issue 183

@bkarge
Copy link
Contributor Author

bkarge commented Jun 4, 2015

@dkocher fixed the accidental revert!

@bkarge bkarge changed the title Issue 183 fix for issue 183 (buffer overrun in sftp.RemoteFile.ReadAheadRemoteFileInputStream) Jun 4, 2015
@hierynomus
Copy link
Owner

Hi bkarge,

This is a very nice fix, could you add 2 things:

  1. The test that shows the condition is now fixed, you've attached a sample case to the ReadAheadRemoteFileInputStream #183 issue, but I would very much welcome that as a testcase using for instance an Apache Mina SSHD server.
  2. Apply the same formatting as the codebase currently has.
    2.1. No spaces between the braces of a method call and the arguments
    2.2. Curlies also for single-line if-statements
    2.3. else if on the same line

Thanks! Looking forward to merging this!

@bkarge
Copy link
Contributor Author

bkarge commented Jun 17, 2015

Hi hierynomus,

I have a workaround for the bug in my code base and I'm not sure I have enough remaining capacity to implement the above requirements.

Good luck!

@hierynomus hierynomus merged commit 14edb33 into hierynomus:master Jun 17, 2015
@hierynomus
Copy link
Owner

I've done it for you :). Thanks for the PR!

@bkarge
Copy link
Contributor Author

bkarge commented Jun 17, 2015

Thanks a lot!! It would certainly have taken me an hour or so to figure out the sshj test environment and to fight my autoformatter fighting me doing good. Hope it took you just a couple of clicks..

Cheers!

@hierynomus hierynomus added this to the 0.13.0 milestone Jun 17, 2015
@bkarge bkarge deleted the issue-183 branch June 17, 2015 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants