Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to check if we can depened on the JS lib web3 that is LGPL-3.0 licensed #31

Closed
hendrikebbers opened this issue Oct 10, 2024 · 3 comments
Assignees
Labels
hashgraph transfer Related to the transfer of the Hashgraph projects license issue

Comments

@hendrikebbers
Copy link
Member

hendrikebbers commented Oct 10, 2024

The hedera-mirror-node-explorer depends on web3@4.13.0 (and related libs like web3-eth@4.9.0). The license of the complete web3js project is LGPL-3.0 (see https://github.com/web3/web3.js/blob/4.x/LICENSE).

We need to check if the dependency is ok or need to be fixed. Since hedera-mirror-node-explorer is a product that we release including all dependencies I assume we have a problem here...

More details can be found at #15

@rbair23
Copy link
Contributor

rbair23 commented Oct 11, 2024

We may need to switch to use ethers.js instead (it is MIT licensed)

@hendrikebbers hendrikebbers added the hashgraph transfer Related to the transfer of the Hashgraph projects label Nov 19, 2024
@hendrikebbers
Copy link
Member Author

@svienot
Copy link

svienot commented Feb 10, 2025

The explorer dependency on web3 was indirect. Explorer depends on @hedera-name-service/hns-resolution-sdk which in turns used to depend on web3.

This PR has bumped the explorer dependency from @hedera-name-service/hns-resolution-sdk 2.0.11 to 2.0.12, which does no longer depend on web3.

The issue is resolved, I think we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashgraph transfer Related to the transfer of the Hashgraph projects license issue
Projects
None yet
Development

No branches or pull requests

5 participants