Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send "verify email" emails after magic sign-in #8870

Open
jnaviask opened this issue Aug 16, 2024 · 0 comments · May be fixed by #9306
Open

Do not send "verify email" emails after magic sign-in #8870

jnaviask opened this issue Aug 16, 2024 · 0 comments · May be fixed by #9306
Assignees
@rbennettcw
Labels
1 1-2 hour task bug Something isn't working S2 Sprint 2 S3 Sprint 3 S4 S5 S6

Comments

@jnaviask
Copy link
Collaborator

Description

We call /updateEmail as part of the Magic login flow, which is not only unnecessary but sends out an email to users asking them to take an action that doesn't make sense. We should remove this /updateEmail call unless a user specifically, manually changes their (internal) email address.
@jnaviask jnaviask added bug Something isn't working needs estimate labels Aug 16, 2024
@jnaviask jnaviask self-assigned this Aug 16, 2024
@jnaviask jnaviask added S2 Sprint 2 S3 Sprint 3 labels Aug 26, 2024
@jnaviask jnaviask added the S4 label Sep 6, 2024
@jnaviask jnaviask assigned rbennettcw and unassigned jnaviask Sep 11, 2024
@jnaviask jnaviask added the S5 label Sep 15, 2024
@rbennettcw rbennettcw added 1 1-2 hour task and removed needs estimate labels Sep 23, 2024
@rbennettcw rbennettcw linked a pull request Sep 23, 2024 that will close this issue
Open
@dillchen dillchen added the S6 label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbennettcw rbennettcw

Labels
1 1-2 hour task bug Something isn't working S2 Sprint 2 S3 Sprint 3 S4 S5 S6
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent verification email after signup hicommonwealth/commonwealth
3 participants
@jnaviask @dillchen @rbennettcw