From e3c7f76332bcf42c715876d25ec0194250bcd959 Mon Sep 17 00:00:00 2001 From: Khash Sajadi Date: Wed, 10 May 2023 13:47:40 -0700 Subject: [PATCH 1/2] Include registration error in the log --- periodic_task_manager.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/periodic_task_manager.go b/periodic_task_manager.go index 085ca3d7d..169ae5733 100644 --- a/periodic_task_manager.go +++ b/periodic_task_manager.go @@ -173,8 +173,8 @@ func (mgr *PeriodicTaskManager) add(configs []*PeriodicTaskConfig) { for _, c := range configs { entryID, err := mgr.s.Register(c.Cronspec, c.Task, c.Opts...) if err != nil { - mgr.s.logger.Errorf("Failed to register periodic task: cronspec=%q task=%q", - c.Cronspec, c.Task.Type()) + mgr.s.logger.Errorf("Failed to register periodic task: cronspec=%q task=%q err=%v", + c.Cronspec, c.Task.Type(), err) continue } mgr.m[c.hash()] = entryID From 5eb1ade33cbda548c23be21bccee5566d5127ccc Mon Sep 17 00:00:00 2001 From: Khash Sajadi Date: Wed, 10 May 2023 20:35:59 -0700 Subject: [PATCH 2/2] remove chatty debug log this will show in the logs every 5 seconds as debug (not even trace) which leads to a lot of noise --- scheduler.go | 1 - 1 file changed, 1 deletion(-) diff --git a/scheduler.go b/scheduler.go index 2655a946b..0fb25ee4f 100644 --- a/scheduler.go +++ b/scheduler.go @@ -298,7 +298,6 @@ func (s *Scheduler) beat() { } entries = append(entries, e) } - s.logger.Debugf("Writing entries %v", entries) if err := s.rdb.WriteSchedulerEntries(s.id, entries, 5*time.Second); err != nil { s.logger.Warnf("Scheduler could not write heartbeat data: %v", err) }