-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to pandas 1.0.4 prior to release #33
Comments
Now
But not sure if all should pass or some are expected to fail |
@andrewgsavage i think you did most of the heavy lifting, any thoughts? |
Update:
Things that re failing that I think should not:
|
Update:
|
Update:
|
My last look at it was here. I also had trouble with the TestMethods.test_where_series test |
Looks nasty. @hgrecco how would you feel about xfailing the remaining tests and doing a 0.1.0dev release just to reserve the name on pypi and conda? Yes it's full of bugs, but I can't see a fast fix for #29 given you have to somehow remove the |
Update:
|
@znicholls I actually agree. Adoption will help to find and fix bugs. And 21 failing and 331 passing is not so bad for a 0.1 |
This discussion is one of the reasons preventing me to release Pint 1.0. Looking at the the error in pint-pandas, I found that many of the problems arise form a wrong result in >>> import numpy as np
>>> x = np.zeros(3)
>>> y = np.asarray(3)
>>> type(x)
<class 'numpy.ndarray'>
>>> type(y)
<class 'numpy.ndarray'>
>>> x
array([0., 0., 0.])
>>> y
array(3)
>>> len(x)
3
>>> len(y)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: len() of unsized object
>>> iter(x)
<iterator object at 0x7f8831837af0>
>>> iter(y)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: iteration over a 0-d array
>>> from pandas._libs import lib
>>> lib.is_list_like(x)
True
>>> lib.is_list_like(y)
False Can we copy from it? |
Here 'it' being ndarray? |
Yes. I trying to look how it is done. It is weird because Quantity raises TypeError (like ndarray) upon calling |
|
looks like that'll be the key |
I think |
That is indeed the case! Tomorrow I will make a release of pint-pandas and open and issue in Pint |
Hey @hgrecco, just wanted to see if that release ended up happening? |
We release on friday no matter what, but this looks very promising: hgrecco/pint#1125 |
I did it today as after several tries, I think that hgrecco/pint#1125 won't work |
The current status for the tests (run in my computer) is:
The text was updated successfully, but these errors were encountered: