Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Images on DMs (XMTP) #2791

Closed
2 tasks done
petermdenton opened this issue May 3, 2023 · 1 comment
Closed
2 tasks done

Add Support for Images on DMs (XMTP) #2791

petermdenton opened this issue May 3, 2023 · 1 comment
Assignees

Comments

@petermdenton
Copy link

Summary

Overview

Adding images to the DM experience would bring more engagement to users messaging across Lenster. Images would make the messaging experience on par with other messaging platform user experiences and open the door to more and more engaging attachments across Lens.

User Experience

As you can see in the video below, a user can:

  • click to upload and attach an image to their conversation
  • select from the default image picker on their machine (filtered to images)
  • see a preview of the file they are about to upload
  • click to upload file and see a status of the file being uploaded
  • submit the image in the chat and see it as part of the conversation

Watch the video below:
https://user-images.githubusercontent.com/483/227057859-b5dd6059-cdd5-4224-81ac-22d97029afe9.mov

In the video above, we (XMTP) have used the newly introduced Attachment and RemoteAttachment content types which you can read more about here: https://xmtp.org/blog/attachments-and-remote-attachments.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)

PR for Feature

The PR is available in this branch:
#2149

@bigint
Copy link
Member

bigint commented May 4, 2023

This is a great idea 🚀

My only concern is uploading images as base64 to xmtp might not be a good idea for lenster, as it takes too long to load, and me miss some features like distributing images to CDN, transcoding etc.

We also don't want to show loading while loading and image, if we use CDN it will be near instant on further loads.

I suggest to use traditional ipfs uploader where we already used in new posts/comments component.

@heyverse heyverse locked and limited conversation to collaborators May 6, 2023
@bigint bigint converted this issue into discussion #2817 May 6, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants