Skip to content
This repository has been archived by the owner on Jan 11, 2022. It is now read-only.

fix: import * from Joi #6

Merged
merged 1 commit into from
Oct 17, 2019
Merged

fix: import * from Joi #6

merged 1 commit into from
Oct 17, 2019

Conversation

kylealwyn
Copy link
Contributor

@kylealwyn kylealwyn commented Oct 17, 2019

import Joi, { JoiObject, SchemaMap } from 'joi'; was compiling incorrectly. We could either switch over to the es6 module resolution strategy or switch our import strategy. Switching import strategy is easier. Tested API locally w/ yalc.

Before

var joi_1 = require("joi")

joi_1.default.object(schema))

After

var Joi = require("joi");

Joi.object(schema)

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@85193a3). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #6   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?     60           
  Branches          ?     13           
=======================================
  Hits              ?     60           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85193a3...6204fe0. Read the comment docs.

@kylealwyn kylealwyn merged commit c57b27f into master Oct 17, 2019
@kylealwyn kylealwyn deleted the fix/joi-import branch October 17, 2019 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants