-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
determine how best to perform testing #29
Comments
I would definitely like to see the testing approach that you guys will take, currently once can only test non DOM based code. Would be nice to get such level of tests for the visual end and dom based functions as well. |
I'd like to have something like React's shallow rendering, see https://facebook.github.io/react/docs/test-utils.html#shallow-rendering. Such testing is easy to reason about, tests only one component at a time, requires no DOM and thus might even run with |
That sounds great @neelance ! I like the idea of that a lot :) I will see if I can find time to look into it. |
I also think that component based testing is the way to initially go. They are unit tests of that unit / component. |
@slimsag I'm struggling a little bit trying to determine the best way to test more complex element hierarchies. I feel like maybe we need a higher-order wrapper for the |
I'm pretty much blocked on doing any further work until we either decide what to do about #115, or work out how to go about testing trees of elements. |
Sorry I haven't had a chance to look at this yet @pdf -- I think we just need to add some more extensive helper utility functions to our test suite but I haven't had time to figure out which are needed / write them. I'll gladly accept idea's/PRs in this area if anyone wants to beat me to it. I've responded on #115 and think we can find a solution there very soon (perhaps today) |
as it requires a browser DOM to be present, etc.
The text was updated successfully, but these errors were encountered: