Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

determine how best to perform testing #29

Open
emidoots opened this issue Feb 13, 2016 · 7 comments
Open

determine how best to perform testing #29

emidoots opened this issue Feb 13, 2016 · 7 comments

Comments

@emidoots
Copy link
Member

as it requires a browser DOM to be present, etc.

@influx6
Copy link

influx6 commented Feb 15, 2016

I would definitely like to see the testing approach that you guys will take, currently once can only test non DOM based code. Would be nice to get such level of tests for the visual end and dom based functions as well.

@neelance
Copy link
Contributor

I'd like to have something like React's shallow rendering, see https://facebook.github.io/react/docs/test-utils.html#shallow-rendering. Such testing is easy to reason about, tests only one component at a time, requires no DOM and thus might even run with gc.

@emidoots
Copy link
Member Author

That sounds great @neelance ! I like the idea of that a lot :) I will see if I can find time to look into it.

@joeblew99
Copy link

I also think that component based testing is the way to initially go. They are unit tests of that unit / component.

@pdf
Copy link
Contributor

pdf commented Jun 30, 2017

@slimsag I'm struggling a little bit trying to determine the best way to test more complex element hierarchies. I feel like maybe we need a higher-order wrapper for the mockObject, but I'm not entirely sure of the best way to track element identity, to test for correct order, etc - ideally I'd like to sort this out in a way that allows table-driven testing for maintenance.

@pdf
Copy link
Contributor

pdf commented Jul 8, 2017

I'm pretty much blocked on doing any further work until we either decide what to do about #115, or work out how to go about testing trees of elements.

@emidoots
Copy link
Member Author

emidoots commented Jul 8, 2017

Sorry I haven't had a chance to look at this yet @pdf -- I think we just need to add some more extensive helper utility functions to our test suite but I haven't had time to figure out which are needed / write them. I'll gladly accept idea's/PRs in this area if anyone wants to beat me to it.

I've responded on #115 and think we can find a solution there very soon (perhaps today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants