feat: allow attaching firewalls to the server #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
server-firewalls
branch
from
bfde81c to
5dc3f21
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 33.56% 33.69% +0.13%
==========================================
Files 12 12
Lines 727 739 +12
==========================================
+ Hits 244 249 +5
- Misses 454 459 +5
- Partials 29 31 +2 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Aug 14, 2024
|
A test for this would also be nice. |
|
I added a global step test, but to really test this, I'd need to do a bigger refactor to break down the long step into smaller chunks. I'll do this in a future PR. |
jooola
pushed a commit
that referenced
this pull request
Aug 14, 2024
🤖 I have created a release *beep* *boop* --- ## [1.6.0](v1.5.4...v1.6.0) (2024-08-14) ### Features * allow attaching firewalls to the server ([#221](#221)) ([73f10e4](73f10e4)) ### Bug Fixes * check if the image was found ([#223](#223)) ([da3b49b](da3b49b)), closes [#222](#222) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157
This allows to attach a list of firewalls using their names or the IDs.