Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong client option name for poll backoff func #213

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Jul 23, 2024

The hcloud client option name was using the retry back off option instead of the poll back off option.

@jooola jooola requested a review from a team as a code owner July 23, 2024 13:53
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.94%. Comparing base (32e6479) to head (f7b4b29).

Files Patch % Lines
builder/hcloud/builder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   33.56%   31.94%   -1.62%     
==========================================
  Files          12       12              
  Lines         727      576     -151     
==========================================
- Hits          244      184      -60     
+ Misses        454      363      -91     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 4da0192 into main Jul 23, 2024
10 checks passed
@jooola jooola deleted the wrong-option-poll branch July 23, 2024 13:58
jooola pushed a commit that referenced this pull request Aug 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.5.4](v1.5.3...v1.5.4)
(2024-08-06)


### Bug Fixes

* wrong client option name for poll backoff func
([#213](#213))
([4da0192](4da0192))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant