fix: wait server firewall actions to settle #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 33.04% 33.56% +0.51%
==========================================
Files 12 12
Lines 702 727 +25
==========================================
+ Hits 232 244 +12
- Misses 445 454 +9
- Partials 25 29 +4 ☔ View full report in Codecov by Sentry. |
Closes #205 Prevents a server 'locker' error from the API, when trying to change the type of the server, while some 'firewall_apply' are still running in the backend. The 'firewall_apply' actions are triggered by label selectors.
jooola
force-pushed
the
fix-change-server-type-server-locked
branch
from
37c4873 to
62d6b62
Compare
apricote
approved these changes
Jul 5, 2024
jooola
pushed a commit
that referenced
this pull request
Jul 9, 2024
🤖 I have created a release *beep* *boop* --- ## [1.5.3](v1.5.2...v1.5.3) (2024-07-09) ### Bug Fixes * wait server firewall actions to settle ([#209](#209)) ([2d58893](2d58893)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205
Prevents a server
lockederror from the API, when trying to change the type of the server, whilefirewall_applyare still running in the backend.The
firewall_applyactions are triggered by label selectors.