fix: use first host ip in public ipv6 network #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I rushed the implementation of #190 and didn't implement tests. This PR corrects this. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 32.11% 33.42% +1.31%
==========================================
Files 11 11
Lines 685 694 +9
==========================================
+ Hits 220 232 +12
+ Misses 441 437 -4
- Partials 24 25 +1 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Jun 5, 2024
jooola
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [1.5.1](v1.5.0...v1.5.1) (2024-06-06) ### Bug Fixes * use first host ip in public ipv6 network ([#192](#192)) ([77bb637](77bb637)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the public net ipv6 is a network (CIDR block), we must use the next host IP in that network.