Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable hcloud-go debug logging #167

Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat: enable hcloud-go debug logging #167

merged 1 commit into from
Apr 22, 2024

Conversation

apricote
Copy link
Member

Packer automatically redirects the output from go log to wherever it needs to be. If users set PACKER_LOG=1, the logs will be printed to stderr.

https://developer.hashicorp.com/packer/docs/plugins/creation#logging-and-debugging

Closes #165

Packer automatically redirects the output from go stdlib "log" to
wherever it needs to be. If users set `PACKER_LOG=1`, the logs will be
printed to `stderr`.
@apricote apricote self-assigned this Apr 19, 2024
@apricote apricote requested a review from a team as a code owner April 19, 2024 07:59
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.51%. Comparing base (0556e35) to head (dbc0a11).

Files Patch % Lines
builder/hcloud/builder.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   29.64%   29.51%   -0.14%     
==========================================
  Files          11       11              
  Lines         651      654       +3     
==========================================
  Hits          193      193              
- Misses        433      436       +3     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apricote apricote merged commit 1ab544e into main Apr 22, 2024
10 checks passed
@apricote apricote deleted the debug-logs branch April 22, 2024 08:50
apricote pushed a commit that referenced this pull request May 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.4.0](v1.3.0...v1.4.0)
(2024-05-06)


### Features

* enable hcloud-go debug logging
([#167](#167))
([1ab544e](1ab544e)),
closes
[#165](#165)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: clear message on why snapshot creation failed
2 participants