Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Just started working on a Rails version... #26

Open
sbleon opened this issue Sep 7, 2013 · 3 comments
Open

Just started working on a Rails version... #26

sbleon opened this issue Sep 7, 2013 · 3 comments

Comments

@sbleon
Copy link

sbleon commented Sep 7, 2013

Hi! I just started working on a Rails deployment heroku plugin: https://github.com/singlebrook/heroku-deploy

We're using the same namespace for our commands. It would be cool if we could find a way to work together. We could aim to have heroku-deploy contain deployment strategies (which is where I was heading), or we could have sub-projects for each strategy. I bet we could find a way for heroku deploy to list all available deployment strategies from sub-projects. That might be easier than sharing them all in one repo.

I'm open to either way. What do you think?

@sbleon
Copy link
Author

sbleon commented Sep 11, 2013

Hi again. I renamed my plugin to heroku-deploy-rails. I think yours should probably be heroku-deploy-war. Let me know if you change it, because right now my heroku deploy command will look for heroku-deploy in order to know if deploy:war is a valid strategy.

Your heroku deploy could do something analogous to what mine does: https://github.com/singlebrook/heroku-deploy-rails/blob/master/lib/deploy/heroku/command/deploy.rb#L11

@AVGP
Copy link

AVGP commented Mar 11, 2015

Hey, just FYI: I've built a generic deploy plugin using the Build API over here which allows to deploy whatever you've got. Even if you're not using git at all - it uses the new Platform API.

That allows for more flexibility as you can use whatever you've got to prepare a tarball (or zip, FWIW) that's ready to be deployed, have it uploaded to the Sources endpoint of the Platform API and then create a build from it.

It's not about WAR deployments, which are related to deploying JVM-based projects.

This plugin, however is generic and uses the new [https://devcenter.heroku.com/articles/developing-toolbelt-plug-ins](node.js based plugin architecture) together with the Platform API.

However, your remark about the namespacing is valid and I'll probably use deploy:archive instead.

@AVGP
Copy link

AVGP commented Mar 11, 2015

Edit: Whoops, I thought this was in my heroku-deploy repository xD
Neeevermind!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants