Skip to content

Commit

Permalink
Clean up supported [[stacks]] lists
Browse files Browse the repository at this point in the history
* Removes redundant explicitly named stacks for any buildpack
  that already supported the wildcard stack.
* Switches the corepack buildpack to using the wildcard stack
  (since it doesn't contain anything stack-specific).
* Drops support for the bionic stack from the engine buildpack,
  since bionic is Ubuntu 18.04, which is EOL (and Heroku-18 support
  has already been dropped).
  • Loading branch information
edmorley committed Oct 24, 2023
1 parent 580f380 commit 427f9d4
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 46 deletions.
1 change: 1 addition & 0 deletions buildpacks/nodejs-corepack/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Updated buildpack description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))
- Switched from supporting explicitly named stacks to supporting the wildcard stack. ([#693](https://github.com/heroku/buildpacks-nodejs/pull/693))

## [1.1.7] - 2023-10-17

Expand Down
8 changes: 1 addition & 7 deletions buildpacks/nodejs-corepack/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,7 @@ keywords = ["corepack", "heroku"]
type = "MIT"

[[stacks]]
id = "heroku-20"

[[stacks]]
id = "heroku-22"

[[stacks]]
id = "io.buildpacks.stacks.bionic"
id = "*"

[metadata.release]
image = { repository = "docker.io/heroku/buildpack-nodejs-corepack" }
4 changes: 4 additions & 0 deletions buildpacks/nodejs-engine/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Updated buildpack description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

### Removed

- Dropped support for the end of life `io.buildpacks.stacks.bionic` stack. ([#693](https://github.com/heroku/buildpacks-nodejs/pull/693))

## [1.1.7] - 2023-10-17

- Added Node.js version 20.8.1.
Expand Down
3 changes: 0 additions & 3 deletions buildpacks/nodejs-engine/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,5 @@ id = "heroku-20"
[[stacks]]
id = "heroku-22"

[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata.release]
image = { repository = "docker.io/heroku/buildpack-nodejs-engine" }
9 changes: 0 additions & 9 deletions buildpacks/nodejs-npm-engine/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,5 @@ type = "MIT"
[[stacks]]
id = "*"

[[stacks]]
id = "heroku-20"

[[stacks]]
id = "heroku-22"

[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata.release]
image = { repository = "docker.io/heroku/buildpack-nodejs-npm-engine" }
4 changes: 4 additions & 0 deletions buildpacks/nodejs-pnpm-install/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Updated buildpack description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

### Removed

- Removed redundant explicitly named supported stacks. ([#693](https://github.com/heroku/buildpacks-nodejs/pull/693))

## [1.1.7] - 2023-10-17

- No changes.
Expand Down
9 changes: 0 additions & 9 deletions buildpacks/nodejs-pnpm-install/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,5 @@ type = "MIT"
[[stacks]]
id = "*"

[[stacks]]
id = "heroku-20"

[[stacks]]
id = "heroku-22"

[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata.release]
image = { repository = "docker.io/heroku/buildpack-nodejs-pnpm-install" }
4 changes: 4 additions & 0 deletions buildpacks/nodejs-yarn/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Updated buildpack description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

### Removed

- Removed redundant explicitly named supported stacks. ([#693](https://github.com/heroku/buildpacks-nodejs/pull/693))

## [1.1.7] - 2023-10-17

- Added Yarn version 4.0.0-rc.53.
Expand Down
9 changes: 0 additions & 9 deletions buildpacks/nodejs-yarn/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,5 @@ type = "MIT"
[[stacks]]
id = "*"

[[stacks]]
id = "heroku-20"

[[stacks]]
id = "heroku-22"

[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata.release]
image = { repository = "docker.io/heroku/buildpack-nodejs-yarn" }
4 changes: 4 additions & 0 deletions buildpacks/npm/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Updated buildpack display name, description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

### Removed

- Removed redundant explicitly named supported stacks. ([#693](https://github.com/heroku/buildpacks-nodejs/pull/693))

## [1.1.7] - 2023-10-17

- No changes.
Expand Down
9 changes: 0 additions & 9 deletions buildpacks/npm/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,5 @@ type = "MIT"
[[stacks]]
id = "*"

[[stacks]]
id = "heroku-20"

[[stacks]]
id = "heroku-22"

[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata.release]
image = { repository = "docker.io/heroku/buildpack-nodejs-npm" }

0 comments on commit 427f9d4

Please sign in to comment.