Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some typos in description #3

Open
aprozo opened this issue Nov 29, 2023 · 0 comments
Open

Some typos in description #3

aprozo opened this issue Nov 29, 2023 · 0 comments

Comments

@aprozo
Copy link

aprozo commented Nov 29, 2023

Hi, can you please improve some typos:

In README.md on line 10 :
Events that pass the particle-level event selection, but not the particle-level one. ->
Events that pass the particle-level event selection, but not the detector-level one.

in your GaussianExample.ipynb code
pass_reco = np.random.binomial(1,1.-eff,len(theta0_G)) ->
pass_reco = np.random.binomial(1,1.-eff,len(theta0_S))

I wish you could do the same example but more realistic one using, e.g. uproot library and your old https://github.com/ericmetodiev/OmniFold Demo.

With best wishes, Alexandr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant