Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Git submodules #34

Closed
gmgunter opened this issue Feb 19, 2024 · 1 comment · Fixed by #36
Closed

Support for Git submodules #34

gmgunter opened this issue Feb 19, 2024 · 1 comment · Fixed by #36

Comments

@gmgunter
Copy link
Contributor

Thanks for this nice tool!

I noticed that erroneous inconsistencies seem to be reported when the project contains Git submodules.

$ git clone https://github.com/isce-framework/snaphu-py.git
$ cd snaphu-py
$ pipx run check-sdist
[...]
SDist does not match git

SDist only:


Git only:
  ext/snaphu

In this case, ext/snaphu is a Git submodule whose contents are correctly included in the SDist, but git ls-files doesn't list them -- it only prints the top-level submodule directory name.

This could be resolved by adding the --recurse-submodules flag to the git ls-files command (requires Git >=2.11.0). Is that something you'd be interested in adding?

@henryiii
Copy link
Owner

Sure, that was the main issue holding back "1.0" IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants