You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that erroneous inconsistencies seem to be reported when the project contains Git submodules.
$ git clone https://github.com/isce-framework/snaphu-py.git
$ cd snaphu-py
$ pipx run check-sdist
[...]
SDist does not match git
SDist only:
Git only:
ext/snaphu
In this case, ext/snaphu is a Git submodule whose contents are correctly included in the SDist, but git ls-files doesn't list them -- it only prints the top-level submodule directory name.
This could be resolved by adding the --recurse-submodules flag to the git ls-files command (requires Git >=2.11.0). Is that something you'd be interested in adding?
The text was updated successfully, but these errors were encountered:
Thanks for this nice tool!
I noticed that erroneous inconsistencies seem to be reported when the project contains Git submodules.
In this case,
ext/snaphu
is a Git submodule whose contents are correctly included in the SDist, butgit ls-files
doesn't list them -- it only prints the top-level submodule directory name.This could be resolved by adding the
--recurse-submodules
flag to thegit ls-files
command (requires Git >=2.11.0). Is that something you'd be interested in adding?The text was updated successfully, but these errors were encountered: