Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Deprecate JFrog charts (moved to https://github.com/jfrog/charts) #7627

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Deprecate JFrog charts (moved to https://github.com/jfrog/charts) #7627

merged 2 commits into from
Sep 11, 2018

Conversation

eldada
Copy link
Contributor

@eldada eldada commented Sep 9, 2018

What this PR does / why we need it:
This PR deprecates all JFrog charts.
Towards a future of a more distributed nature of helm charts distributions, we (JFrog) have setup our own helm repositories:
Sources: https://github.com/jfrog/charts
Charts repository: https://charts.jfrog.io

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 9, 2018
@eldada
Deprecate JFrog charts (moved to https://github.com/jfrog/charts)
6eb3e7d 
Signed-off-by: Eldad Assis <eldada@jfrog.com>
@eldada eldada mentioned this pull request Sep 9, 2018
Closed
@cpanato
Copy link
Member

cpanato commented Sep 9, 2018

@eldada thanks

Can you add some documentation in the readme.md? Like where people can find the new charts and so on.

@cpanato
Copy link
Member

cpanato commented Sep 9, 2018

/assign

@cpanato
Copy link
Member

cpanato commented Sep 9, 2018

@eldada missing the DCO sign

@eldada
Add note on where to find and get the new charts
9e19f48 
Signed-off-by: Eldad Assis <eldada@jfrog.com>
@eldada
Copy link
Contributor Author

eldada commented Sep 9, 2018

@cpanato - added

@cpanato
Copy link
Member

cpanato commented Sep 9, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 9, 2018
@cpanato
Copy link
Member

cpanato commented Sep 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018
rimusz
rimusz approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@rimusz rimusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, eldada, rimusz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2018
@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 11, 2018
@rimusz
Copy link
Contributor

rimusz commented Sep 11, 2018

/assign @mattfarina

@rimusz
Copy link
Contributor

rimusz commented Sep 11, 2018

/assign @unguiculus

@mattfarina
Copy link
Contributor

/check-dco

@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit d908e03 into helm:master Sep 11, 2018
jicowan pushed a commit to jicowan/charts that referenced this pull request Oct 2, 2018
@eldada @jicowan
Deprecate JFrog charts (moved to https://github.com/jfrog/charts) (he…
8add3b5 
…lm#7627)

* Deprecate JFrog charts (moved to https://github.com/jfrog/charts)

Signed-off-by: Eldad Assis <eldada@jfrog.com>

* Add note on where to find and get the new charts

Signed-off-by: Eldad Assis <eldada@jfrog.com>
Signed-off-by: jenkin-x <jicowan@hotmail.com>
@hoeghh
Copy link
Contributor

hoeghh commented Oct 10, 2018 •
edited
Loading

Why on earth would / can a company deprecate a public helm chart, just because they forked it?
I really dont get that. If Jfrog wants to fork it, fine. But why do they decide if the public one should be deprecated? @oliverisaac @mattfarina @cpanato

@eldada
Copy link
Contributor Author

eldada commented Oct 10, 2018 •
edited
Loading

Hi @hoeghh. I guess I should answer this, as I was the one who initiated this.

  1. Since we (JFrog) added these charts here, we feel that we have the right to also deprecate them. We followed the documented process
  2. The deprecation means they are just not supported here. The charts are still available.
  3. A helm search artifactory might be confusing if no deprecation is noted as user might think it to be the official, latest version.
  4. There is a planned move towards a distributed model where multiple repositories each maintain a set of its own charts. See details
  5. JFrog charts (https://github.com/jfrog/charts) are still public and will remain so.

I hope this help explain the rational behind this move.

@hoeghh
Copy link
Contributor

hoeghh commented Oct 10, 2018

Hi @eldada

My comments :

  1. I disagree. If you contribute to Open Source, you dont get to deprecate it. Some one else can take over.
  2. Support is not equal Jfrog. Others / the community can/will support this chart
  3. A search will give people the correct answer. The latest supported in this repo. What Jfrog does, is irrelevant.
  4. You are linking to a proposal.
  5. Irrelevant. I too can make an Artifactory helm chart, that has nothing to do with this one.

If the proposal is approved at some point, then you have a point. Until then, you are (in my mind) hijacking an open source chart and linking to your commercial website.

Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
@eldada @Jnig
Deprecate JFrog charts (moved to https://github.com/jfrog/charts) (he…
b857094 
…lm#7627)

* Deprecate JFrog charts (moved to https://github.com/jfrog/charts)

Signed-off-by: Eldad Assis <eldada@jfrog.com>

* Add note on where to find and get the new charts

Signed-off-by: Eldad Assis <eldada@jfrog.com>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
@scottrigby scottrigby mentioned this pull request Jan 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rimusz rimusz rimusz approved these changes

@seanknox seanknox Awaiting requested review from seanknox

Assignees

@mattfarina mattfarina

@unguiculus unguiculus

@cpanato cpanato

@rimusz rimusz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@eldada @cpanato @k8s-ci-robot @rimusz @mattfarina @hoeghh @unguiculus @ey-bot