This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Apr 12, 2018
Merged
prydonius
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks @tamalsaha!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prydonius, tamalsaha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Apr 12, 2018
#4962 Signed-off-by: tamal <tamal@appscode.com>
Closed
nazarewk
pushed a commit
to nazarewk/charts
that referenced
this pull request
Apr 18, 2018
nazarewk
pushed a commit
to nazarewk/charts
that referenced
this pull request
Apr 18, 2018
helm#4962 Signed-off-by: tamal <tamal@appscode.com>
ichtar
pushed a commit
to Bestmile/charts
that referenced
this pull request
May 15, 2018
ichtar
pushed a commit
to Bestmile/charts
that referenced
this pull request
May 15, 2018
helm#4962 Signed-off-by: tamal <tamal@appscode.com>
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
Signed-off-by: voron <av@arilot.com>
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
helm#4962 Signed-off-by: tamal <tamal@appscode.com> Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
Indicates that a PR is ready to be merged.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4957