Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kibana] deprecating kibana chart #23844

Merged
merged 6 commits into from
Oct 5, 2020

Conversation

monotek
Copy link
Collaborator

@monotek monotek commented Oct 5, 2020

Signed-off-by: André Bauer monotek23@gmail.com

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@monotek monotek mentioned this pull request Oct 5, 2020
10 tasks
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to do a few more things per https://github.com/helm/charts/blob/master/PROCESSES.md#deprecating-a-chart

I made a github PR suggestion for number 3, but you will also need to address number 6 by adding a similar comment in templates/NOTES.txt.

stable/kibana/Chart.yaml Show resolved Hide resolved
stable/kibana/README.md Outdated Show resolved Hide resolved
@scottrigby
Copy link
Member

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 5, 2020
monotek and others added 5 commits October 5, 2020 21:11
Signed-off-by: André Bauer <monotek23@gmail.com>
Signed-off-by: André Bauer <monotek23@gmail.com>
Signed-off-by: André Bauer <monotek23@gmail.com>
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: André Bauer <monotek23@gmail.com>
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: André Bauer <monotek23@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 5, 2020
Signed-off-by: André Bauer <monotek23@gmail.com>
@compleatang
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: compleatang, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/kibana] Migration Tracker
5 participants