This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/kibana] deprecating kibana chart #23844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Oct 5, 2020
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 5, 2020
10 tasks
scottrigby
suggested changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need to do a few more things per https://github.com/helm/charts/blob/master/PROCESSES.md#deprecating-a-chart
I made a github PR suggestion for number 3, but you will also need to address number 6 by adding a similar comment in templates/NOTES.txt
.
helm-bot
removed
the
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
label
Oct 5, 2020
Signed-off-by: André Bauer <monotek23@gmail.com>
Signed-off-by: André Bauer <monotek23@gmail.com>
Co-authored-by: Scott Rigby <scott@r6by.com> Signed-off-by: André Bauer <monotek23@gmail.com>
Co-authored-by: Scott Rigby <scott@r6by.com> Signed-off-by: André Bauer <monotek23@gmail.com>
monotek
force-pushed
the
kibanadeprecate
branch
from
October 5, 2020 19:12
e4efdb2
to
77680ed
Compare
helm-bot
added
the
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
label
Oct 5, 2020
Signed-off-by: André Bauer <monotek23@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: compleatang, monotek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
lgtm
Indicates that a PR is ready to be merged.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Bauer monotek23@gmail.com
Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)