[stable/grafana] deprecate chart

[zanhsieh]

This chart was moved to a new location: https://github.com/grafana/helm-charts

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/mychartname])

[torstenwalter]

@zanhsieh You need to add deprecated: true Like https://github.com/helm/charts/blob/master/stable/jenkins/Chart.yaml then the linting error should be gone.

[scottrigby]

@zanhsieh May I also make a few suggestions about the new repo?

• bring over git history from stable (here are steps to help: Import prometheus chart source code from stable repo with git history prometheus-community/helm-charts#3)
• add CI/CD using Helm GitHub Actions (working demo repo here, with steps in the README https://github.com/helm/charts-repo-actions-demo)
• Invite the existing chart maintainers to help with that repo https://github.com/grafana/helm2-grafana/blob/master/OWNERS
• list the new repo in Artifact Hub https://artifacthub.io/ (the successor of Helm Hub. See Migration to Artifact Hub hub#439. But also if you wish you may list at Helm Hub in the meantime)

[davidkarlsen]

/lgtm

[davidkarlsen]

/retest

[davidkarlsen]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/grafana/OWNERS [davidkarlsen,zanhsieh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mrueg]

@zanhsieh out of curiosity, why is the repo called helm2? Is there one for helm3?

[zanhsieh]

@mrueg
Yes. But nothing over there yet.
https://github.com/grafana/helm3-grafana

[torstenwalter]

You could simplify your life if you would call the repository helm-charts and put both charts in a subfolder named charts

[scottrigby]

Hm, @zanhsieh re #23662 (comment) I don't believe this should have been merged yet. As far as I can tell, the chart at https://github.com/grafana/helm2-grafana is not installable for end users (or if it is, the Readme still instructs users to install stable/grafana). We should revert this PR and un-deprecate the chart (bumping to a new version) until this is complete. Would you like to collaborate on any of the above?

[torstenwalter]

@zanhsieh I could help with the migration. If you want I can prepare a repo including the history, add you as admin and you could transfer it to https://github.com/grafana/.
Could also setup github actions for it similar https://github.com/jenkinsci/helm-charts or https://github.com/scottrigby/prometheus-helm-charts.

Just let me know if you want that help.

[unguiculus]

I very much second what @scottrigby and @torstenwalter say. Bring it over including the history. Also, the chart must in a subfolder named after the chart.

[unguiculus]

Also, it's probably not a good idea to have separate charts for Helm 2 and 3. That would be two codebases for the same thing with the risk that things diverge. I'd stick with Helm 2 for now which is also installable with Helm 3 until Helm 2 reaches EOL which is pretty soon anyways. You can then update the chart for Helm 3 and drop Helm 2 compatibility.

[zanhsieh]

@torstenwalter
I need help with the migration as well as other stuffs, e.g. github actions, branching. Had invited you in helm2-grafana chart.

@unguiculus
Sure.

[paulczar]

I see there are a bunch of charts in the loki repo - https://github.com/grafana/loki/tree/master/production/helm

maybe it would make sense for the grafana folks to create https://github.com/grafana/helm-charts and consolidate them all into one place ?

[torstenwalter]

Accepted the invite. Which charts should be migrated there? Just grafana or also loki? If you list them here then we can migrate them in one go (will be easier).

[zanhsieh]

@torstenwalter
Just grafana chart. I don't have control on loki.

@paulczar
That part is hard for me since have to talk to Daniel Lee from Grafana. I don't work for Grafana; all my previously contact is thru email.

[scottrigby]

@torstenwalter fun idea. you could also bring in loki, and start up the convo with the loki maintainers to see if they'd like to have all the ci/cd and maintenance in once place (if there's a concern about permissions, mention GitHub CODEOWNERS as the solution, as we did for prometheus-community). If they decide to keep it there, the work is done. If they prefer not to have all the grafana charts in the same repo, you would just need to filter it out, and everything else will stay the same. WDYT?

[torstenwalter]

Started the discussion in grafana/loki#2593

[torstenwalter]

Short update: chart is now migrated including history to https://github.com/grafana/helm-charts and GitHub workflows are set up. Deprecation notice will be updated with #23686.