Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cluster-overprovisioner] Deprecate cluster-overprovisioner #23586

Merged

Conversation

mmingorance-dh
Copy link
Contributor

@mmingorance-dh mmingorance-dh commented Aug 20, 2020

Is this a new chart

No

What this PR does / why we need it:

It will add a deprecation notice to stable/cluster-overprovisioner as this chart has been moved to Delivery Hero's Repository.

Which issue this PR fixes

None

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 20, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mmingorance-dh. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmingorance-dh
Copy link
Contributor Author

/label don't merge

@mmingorance-dh
Copy link
Contributor Author

This PR shouldn't be merged until Delivery Hero makes its Helm Repository available.

@mmingorance-dh
Copy link
Contributor Author

/assign @max-rocket-internet

@k8s-ci-robot
Copy link
Contributor

@mmingorance-dh: GitHub didn't allow me to assign the following users: max-rocket-internet.

Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @max-rocket-internet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmingorance-dh
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2020
@mmingorance-dh mmingorance-dh changed the title [stable/cluster-overprovisioner] Deprecate cluster overprovisioner §[stable/cluster-overprovisioner] Deprecate cluster-overprovisioner Aug 20, 2020
@mmingorance-dh mmingorance-dh changed the title §[stable/cluster-overprovisioner] Deprecate cluster-overprovisioner [stable/cluster-overprovisioner] Deprecate cluster-overprovisioner Aug 20, 2020
@mmingorance-dh
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2020
@mmingorance-dh
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@mmingorance-dh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmingorance-dh
Copy link
Contributor Author

@paulczar do you mind to review this PR?
We have released our own Helm Registry at Delivery Hero and we want to deprecate this chart from helm/stable

@max-rocket-internet
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 28, 2020
@max-rocket-internet
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 28, 2020
@max-rocket-internet
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@mmingorance-dh mmingorance-dh force-pushed the deprecate-cluster-overprovisioner branch 3 times, most recently from 542007b to 5f296bc Compare August 28, 2020 12:25
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2020
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2020
@max-rocket-internet
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@max-rocket-internet: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miguel Mingorance and others added 4 commits August 28, 2020 14:33
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>

Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>

Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Co-authored-by: Max Williams <8859277+max-rocket-internet@users.noreply.github.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>

Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
@mmingorance-dh mmingorance-dh force-pushed the deprecate-cluster-overprovisioner branch from 5f296bc to 2081d1a Compare August 28, 2020 12:35
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2020
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 28, 2020
@max-rocket-internet
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: max-rocket-internet, mmingorance-dh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit ff7ae1c into helm:master Aug 28, 2020
@mmingorance-dh mmingorance-dh deleted the deprecate-cluster-overprovisioner branch August 28, 2020 12:53
@mmingorance-dh mmingorance-dh restored the deprecate-cluster-overprovisioner branch October 1, 2020 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants