Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Allow option to create additional Ingress for health endpoints #23450

Closed
wants to merge 5 commits into from
Closed

[stable/prometheus-operator] Allow option to create additional Ingress for health endpoints #23450

wants to merge 5 commits into from

Conversation

boxcee
Copy link
Contributor

@boxcee boxcee commented Aug 5, 2020

Is this a new chart

No

What this PR does / why we need it:

It allows a user to expose the health endpoint using a different Ingress than the 'main' Ingress. This allows to protect the main endpoint using the auth-directive, but leaving the health endpoint unprotected for status checks (Pingdom, StatusCake etc.).

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: boxcee
To complete the pull request process, please assign gianrubio
You can assign the PR to them by writing /assign @gianrubio in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @boxcee. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 5, 2020
Moritz Schmitz von Hülst added 3 commits August 5, 2020 11:49
Signed-off-by: Moritz Schmitz von Hülst <msc@marketlogicsoftware.com>
Signed-off-by: Moritz Schmitz von Hülst <msc@marketlogicsoftware.com>
Signed-off-by: Moritz Schmitz von Hülst <msc@marketlogicsoftware.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 5, 2020
Moritz Schmitz von Hülst added 2 commits August 5, 2020 12:10
Signed-off-by: Moritz Schmitz von Hülst <msc@marketlogicsoftware.com>
Signed-off-by: Moritz Schmitz von Hülst <msc@marketlogicsoftware.com>
@scottrigby
Copy link
Member

scottrigby commented Aug 12, 2020

/hold

Let’s hold PRs to prometheus-operator for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020
@scottrigby
Copy link
Member

@boxcee as a user and contributor, would you mind helping to review/test this PR? prometheus-community/helm-charts#1

No need to reply here. If you can, please just reply and help there. It would help this process move along faster. Thanks!

@scottrigby
Copy link
Member

🚧 This chart is now deprecated.

Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the kube-prometheus project stack, within which Prometheus Operator is only one component.

If applicable, please re-open this PR there. Thanks!

@scottrigby scottrigby closed this Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants