Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

stable/grafana: support setting revisionHistoryLimit on deployment #23109

Closed
wants to merge 2 commits into from
Closed

stable/grafana: support setting revisionHistoryLimit on deployment #23109

wants to merge 2 commits into from

Conversation

demon
Copy link

@demon demon commented Jul 8, 2020

What this PR does / why we need it:

Makes revisionHistoryLimit configurable/disable-able. Default in values.yaml set to k8s default of 10, so upgrade will provide no change in behavior -- bumped chart version nonetheless.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@demon
stable/grafana: support setting revisionHistoryLimit on deployment
bd3f0ff 
Signed-off-by: Chad Horohoe <chad@horohoe.email>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: demon
To complete the pull request process, please assign zanhsieh
You can assign the PR to them by writing /assign @zanhsieh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 8, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @demon. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@demon
Copy link
Author

demon commented Jul 8, 2020

/assign @zanhsieh

zanhsieh
zanhsieh reviewed Jul 8, 2020
View reviewed changes
stable/grafana/Chart.yaml Outdated Show resolved Hide resolved
zanhsieh
zanhsieh reviewed Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@zanhsieh zanhsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 8, 2020
@demon
Bump chart version to 5.3.6 per feedback
d4c00a9 
Signed-off-by: Chad Horohoe <chad@horohoe.email>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 8, 2020
@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2020
@zanhsieh
Copy link
Collaborator

/test pull-charts-e2e

@k8s-ci-robot
Copy link
Contributor

@demon: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-charts-e2e d4c00a9 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zanhsieh
Copy link
Collaborator

@demon
Could you resolve the conflict file again please? Thank you.

@stale
Copy link

stale bot commented Aug 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2020
@davidkarlsen
Copy link
Member

This chart is deprecated: #23662
Please submit PRs against: https://github.com/grafana/helm2-grafana

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanhsieh zanhsieh zanhsieh approved these changes

Assignees

@zanhsieh zanhsieh

Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@demon @k8s-ci-robot @zanhsieh @davidkarlsen @helm-bot