Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/efs-provisioner] Add podLabels support #22439

Merged
merged 1 commit into from
May 19, 2020

Conversation

rvolykh
Copy link
Contributor

@rvolykh rvolykh commented May 18, 2020

Signed-off-by: Roman Volykh rvolykh@gmail.com

What this PR does / why we need it:

Useful for Prometheus metrics aggregation.

Which issue this PR fixes

Special notes for your reviewer:

I've bumped patch version, is it okey, or minor version should be bumped instead?

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Roman Volykh <rvolykh@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @rvolykh. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 18, 2020
@mariusv
Copy link
Collaborator

mariusv commented May 18, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2020
@rvolykh
Copy link
Contributor Author

rvolykh commented May 19, 2020

Hello @mariusv,

I have no ability to add the label lgtm. Or we are waiting for @hareku?

@mariusv
Copy link
Collaborator

mariusv commented May 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 19, 2020
@mariusv
Copy link
Collaborator

mariusv commented May 19, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mariusv, rvolykh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit eb847e1 into helm:master May 19, 2020
steakunderscore added a commit to steakunderscore/charts that referenced this pull request May 20, 2020
* upstream/master: (46 commits)
  [stable/anchore-engine] Fix upgrade jobs (helm#22451)
  Update MongoDB Exporter (helm#22241)
  [stable/efs-provisioner] Add podLabels support (helm#22439)
  [stable/rabbitmq-ha]  add configuration for initContainer (helm#22005)
  fix: missing labels in secret object (helm#21756)
  [stable/openebs]: fix README image repository typo (helm#22445)
  [stable/graylog] Adding option to define environment variables in raw yaml format (helm#22007)
  [stable/anchore-engine] Allow loading custom CA certificate (helm#22440)
  [stable/jenkins] Cleanup agent.yamlTemplate rendering in XML config (helm#22124)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.5.1 (helm#22438)
  [stable/neo4j] Deprecated. replacement: https://github.com/neo4j-contrib/neo4j-helm (helm#22437)
  [stable/jenkins] Render agent.nodeSelector in pod template JCasC (helm#22431)
  [incubator/sparkoperator] Add webhookNamespaceSelector (helm#22434)
  [stable/jenkins] Adding override for ingress paths (helm#22400)
  stable/unifi implements subPath functionality (helm#22432)
  [stable/prometheus] Add Namespace to applicable Resources (helm#22378)
  [incubator/patroni] Update patroni to 1.5-p5 (helm#21986)
  [kube2iam] - add labels to ServiceMonitor (helm#21605)
  [stable/fluent-bit] Enabling dnsConfig option in the Chart (helm#22419)
  [stable/jenkins] add k8s plugin config parameters (helm#22403)
  ...
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
Signed-off-by: Roman Volykh <rvolykh@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
Signed-off-by: Roman Volykh <rvolykh@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
Signed-off-by: Roman Volykh <rvolykh@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
Signed-off-by: Roman Volykh <rvolykh@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/efs-provisioner] podLabels support
4 participants